[Compass App] Booking screen #2380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miquelbeltran
commented
Aug 6, 2024
| @@ -19,7 +19,7 @@ pluginManagement { | |||
| plugins { | |||
| id "dev.flutter.flutter-plugin-loader" version "1.0.0" | |||
| id "com.android.application" version "7.3.0" apply false | |||
| id "org.jetbrains.kotlin.android" version "1.7.10" apply false | |||
| id "org.jetbrains.kotlin.android" version "1.8.0" apply false | |||
There was a problem hiding this comment.
This was a requirement for share_plus
miquelbeltran
commented
Aug 6, 2024
| @@ -3,7 +3,7 @@ import 'package:compass_app/data/repositories/activity/activity_repository_remot | |||
| import 'package:compass_app/utils/result.dart'; | |||
| import 'package:flutter_test/flutter_test.dart'; | |||
|
|
|||
| import '../../../util/fakes/services/fake_api_client.dart'; | |||
| import '../../../../testing/fakes/services/fake_api_client.dart'; | |||
There was a problem hiding this comment.
testing utils have been moved to the top level testing folder. i.e. compass-app/app/testing
miquelbeltran
commented
Aug 6, 2024
| Future<Result<List<Continent>>> getContinents() async { | ||
| return Result.ok([ | ||
| Future<Result<List<Continent>>> getContinents() { | ||
| return SynchronousFuture(Result.ok([ |
There was a problem hiding this comment.
Switched to using SynchronousFuture in tests when possible as I had issues with timeouts in widget tests
|
I've fixed UI navigation on mobile (the back button / pop scope) as well as a couple of warnings on Flutter 3.24.0 |
ericwindmill
approved these changes
Aug 9, 2024
|
Merging it and moving into the next feature, creating a basic auth flow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Booking screen at the end of the main app flow.
After the user selects
Activitys, these get stored in theItineraryConfigand then the user navigates to theBookingScreen.In the
BookingScreen, aBookingis generated with theBookingCreateComponent.This component communicates with multiple repositories, and it is a bit more complex than the average view model, something that we want to show as discussed in the previous PRs.
Screenshots
In the
BookingScreen, the user can tap on "share trip" which displays the OS share sheet functionality. This uses the pluginshare_plus, but the functionality is also wrapped in theBookingShareComponent, which takes aBookingobject and creates a shareable string, then calls to theShare.share()method fromshare_plus. But theshare_plusdependency is also injected into theBookingShareComponent, allowing us to unit test without plugin dependencies.This is an example of a shared booking to instant messaging:
TODO
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.