Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] ExoPlayer 2.9.1, Android 9, Demo fixes #908

Merged
merged 2 commits into from
Nov 20, 2018

Conversation

ened
Copy link
Contributor

@ened ened commented Nov 20, 2018

This upgrades the video_player dependencies on Android to the latest ExoPlayer version, 2.9.1.

Along with that, security requirements for Android 9 have been applied.

ExoPlayer 2.9.1 is now shipped in Java 8 compatible byte code. This is fully supported on modern Android toolchains, however - users will need to upgrade their build.gradle configuration to include the following section, else their builds will break:

android {
    compileOptions {
        sourceCompatibility 1.8
        targetCompatibility 1.8
    }
}

I consider this change inevitable and flutter should always use the latest build environments.
We might want to document it somewhere, though. Also, the plugin / project templates will need a update.

@dnfield
Copy link
Contributor

dnfield commented Nov 20, 2018

Thanks for doing this!

A few minor adjustments/requests, but I think this is a good idea overall!

@dnfield dnfield closed this Nov 20, 2018
@dnfield dnfield reopened this Nov 20, 2018
@ened
Copy link
Contributor Author

ened commented Nov 20, 2018

@dnfield Thank you for reviewing.

Here are the details rgd. the Java 8 language change:
https://developer.android.com/studio/write/java8-support

@dnfield
Copy link
Contributor

dnfield commented Nov 20, 2018

I think the Java 8 stuff should be fine, we're not using Jack or retrolambda.

If you want to update any of the syntax for Java 8 that should be fine, as long as we don't end up using any language features that break earlier version support.

This LGTM, thanks for the contribution!

@dnfield dnfield merged commit 3f8abcf into flutter:master Nov 20, 2018
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
* [video_player] ExoPlayer 2.9.1, Android 9, Demo fixes

* Mark version as 0.8.0, revert gradle wrapper changes (to be published in a separate PR)
andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants