This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
changed the title
[WIP] [Waiting for cirrus fix] Bump version and make app userinfo private
[WIP] [Waiting for testing] Bump version and make app userinfo private
Oct 22, 2018
bparrishMines
changed the title
[WIP] [Waiting for testing] Bump version and make app userinfo private
Bump version and make app userinfo private
Oct 22, 2018
amirh
approved these changes
Oct 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just mention in the PR description and commit message that we never released the plugin with the public app member so this is not a breaking change.
bparrishMines
commented
Oct 23, 2018
|
||
FirebaseApp app; | ||
final FirebaseApp _app; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this version with FirebaseApp was not published yet, this is not a breaking change.
bparrishMines
changed the title
Bump version and make app userinfo private
Bump firebase_auth version
Oct 29, 2018
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
This reverts commit 4f4293f.
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version bump for #781 and
#867