Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Bump firebase_auth version #865

Merged
merged 4 commits into from
Nov 1, 2018
Merged

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Oct 22, 2018

Version bump for #781 and
#867

@bparrishMines bparrishMines changed the title [WIP] [Waiting for cirrus fix] Bump version and make app userinfo private [WIP] [Waiting for testing] Bump version and make app userinfo private Oct 22, 2018
@bparrishMines bparrishMines removed the WIP label Oct 22, 2018
@bparrishMines bparrishMines changed the title [WIP] [Waiting for testing] Bump version and make app userinfo private Bump version and make app userinfo private Oct 22, 2018
Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just mention in the PR description and commit message that we never released the plugin with the public app member so this is not a breaking change.


FirebaseApp app;
final FirebaseApp _app;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this version with FirebaseApp was not published yet, this is not a breaking change.

@bparrishMines bparrishMines changed the title Bump version and make app userinfo private Bump firebase_auth version Oct 29, 2018
@bparrishMines bparrishMines merged commit 7049401 into flutter:master Nov 1, 2018
@bparrishMines bparrishMines deleted the auth_version branch November 1, 2018 22:25
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants