Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Ban string values which clash with special prefixes #798

Merged
merged 2 commits into from
Sep 26, 2018
Merged

Ban string values which clash with special prefixes #798

merged 2 commits into from
Sep 26, 2018

Conversation

mehmetf
Copy link
Contributor

@mehmetf mehmetf commented Sep 26, 2018

This is the result of security review. We don't want apps to maliciously store values that will be interpreted differently when read.

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you add en entry to the changelog and bump the pubspec version?

@mehmetf mehmetf merged commit 0ff11a5 into flutter:master Sep 26, 2018
@mehmetf mehmetf deleted the b1 branch September 27, 2018 03:04
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants