Removes superfluous words from comments #7031
Conversation
asashour
requested review from
cbracken,
cyanglaz,
hellohuanlin,
vashworth,
GaryQian,
camsim99,
bparrishMines,
gaaclarke,
stuartmorgan and
tarrinneal
as code owners
github-actions
bot
added
p: camera
p: file_selector
p: google_maps_flutter
p: google_sign_in
p: image_picker
p: in_app_purchase
p: local_auth
p: path_provider
p: plugin_platform_interface
p: shared_preferences
p: url_launcher
p: video_player
p: webview_flutter
There was a problem hiding this comment.
Thanks for the contribution! Only changes to user-facing comments (i.e., /// comments in exported Dart files) need CHANGELOG entries; the rest fall under the "unless they only affect development of the package" exemption of the policy, so most of the CHANGELOG changes here should be reverted. It looks from skimming like only a handful are user-facing.
| @@ -78,7 +78,7 @@ + (nullable NSDictionary *)dictionaryFromCoordinateBounds:(GMSCoordinateBounds * | |||
| }; | |||
| } | |||
|
|
|||
| + (nullable GMSCameraPosition *)cameraPostionFromDictionary:(nullable NSDictionary *)data { | |||
| + (nullable GMSCameraPosition *)cameraPositionFromDictionary:(nullable NSDictionary *)data { | |||
There was a problem hiding this comment.
@stuartmorgan is this a breaking change?
There was a problem hiding this comment.
Our policy has generally been (except when there's a very specific reason to believe otherwise, which has been super rare) to assume that nobody interacts directly with the native plugin code, so we don't treat changes to its interfaces as breaking. Instead we treat it as an implementation detail of the package.
# Conflicts: # packages/camera/camera_android_camerax/CHANGELOG.md # packages/plugin_platform_interface/CHANGELOG.md # script/tool/CHANGELOG.md # script/tool/pubspec.yaml
# Conflicts: # script/tool/CHANGELOG.md
|
We've just completed the migration of the plugin code to the flutter/packages repository, as described in https://flutter.dev/go/flutter-plugins-repo-migration, and this repository is now being archived. Unfortunately that means that all in-progress PRs here must be moved to flutter/packages. Please see our instructions for an explanation of how to move your PR, and if you have any issues moving your PR please don't hesitate to reach out in the #hackers-ecosystem channel in Discord. Our apologies that your PR was caught in this one-time transition. We're aware that it's disruptive in the short term, and appreciate your help in getting us to a better long-term state! |
And fixes some typos.
This PR fixes flutter/flutter#119223
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.