[camera_platform_interface] Add support for NV21 image format on android (part 1/3)

[acoutts]

This is part 1 of !6985 which adds support for NV21 image streaming on Android. It adds NV21 as an option in ImageFormatGroup.

This should be merged first because the updates to camera and camera_android in parts 2/3 both require this change.

List which issues are fixed by this PR. You must list at least one issue.

• [camera] Image stream data is corrupt on some Android devices (Vivo, Xiaomi, Motorola) flutter#118350

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
• I signed the CLA.
• The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
• I listed at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[acoutts]

cc @camsim99

[acoutts]

Can anyone help me understand how to satisfy this PR check?

�[31m When bumping the version for release, the NEXT section should be incorporated into the new version's release notes.�[0m

I followed the guide where in this case there is already a NEXT entry so I rolled that item into my new changelog item for 2.4.0 but still getting that error.
https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog-style

[acoutts]

@stuartmorgan do you know how to fix the submit-queue failing job for win32?

[acoutts]

This is all set for a review now @bparrishMines -- all CI tasks look to have passed.

[stuartmorgan-g]

@stuartmorgan do you know how to fix the submit-queue failing job for win32?

submit-queue reflects the current state of the tree, and is unrelated to the PR, so you can always ignore it during development. It shows up here to prevent PRs from landing while the tree is red.

[jomagsm]

This is part 1 of !6985 which adds support for NV21 image streaming on Android. It adds NV21 as an option in ImageFormatGroup.

This should be merged first because the updates to camera and camera_android in parts 2/3 both require this change.

List which issues are fixed by this PR. You must list at least one issue.

• [camera] Image stream data is corrupt on some Android devices (Vivo, Xiaomi, Motorola) flutter#118350

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
• I signed the CLA.
• The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
• I listed at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Are you working on this bug?

[acoutts]

These 3 PRs fix the issue I linked, correct.

[bparrishMines]

@acoutts This feature needs to go through the process of updating a federated plugin and get a PR approved that contains the changes for the platform interface and the Android platform implementation https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins

And it looks like you already created a PR that contains the changes: #6985

I can reopen that PR if you would like to use that one.

[acoutts]

@bparrishMines i thought I would need 3 separate PRs to do this, because first we have to publish a new version of camera_platform_interface before we can publish the new versions of camera and camera_android which rely on it. Is that not the case?

[bparrishMines]

You are correct that the code will need to be submitted in 3 separate PRs. However, we review the changes for each package in a single combined PR. This ensures that the changes made in the implementation packages work with the changes made in the platform interface. See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins

[acoutts]

I understand now - yes please let's re-open that and we can use that for the review. I'll have to double check the changes and sync things up again but I'll get it cleaned up.

[stuartmorgan-g]

Marking as draft until #6985 is reviewed.