Vision cloud label detection

[DennisAlund]

This is an implementation of the cloud based API in ML Kit for Firebase

I found that the cloud based APIs were missing and wrote one straight off due to personal need in a planned workshop. I haven't reported this in any feature request, but I figured that it would be part of the roadmap.

[DennisAlund]

The issues are noted.

[DennisAlund]

Hey, @bparrishMines I see that you've been writing most of the ml-vision plugin. I tried to add support for cloud labeling of images. But I'm a bit stumped by the failing build here.

It builds and runs fine for me locally and I can't make out what action I could take to fix the breaking build.

Any ideas or pointers?

[bparrishMines]

Hi @DennisAlund,

Could you do a git pull? That may help with some of the errors for the PLUGIN_SHARDING check.

Also, this error may be the culprit for the build issue:

/var/folders/xb/469gd9j941bc7v3mltn7zgb40000gn/T/cirrus-ci-build/packages/firebase_ml_vision/ios/Classes/CloudLabelDetector.m:43:37: error: no visible @interface for 'NSNumber' declares the selector 'uintValue'
      detector.maxResults = [maxResults uintValue];

[DennisAlund]

Thanks for spotting that @bparrishMines, I coded the ios part a bit in the dark on my pc.

[DennisAlund]

Any other ideas on the current build errors @bparrishMines? I don't have XCode to test on myself, so I am a bit lost on troubleshooting the iOS parts. I'd be happy if there's someone in the community that could give some insights.

[bparrishMines]

Yea, if you click on details for either of the failed PLUGIN_SHARDING checks, you can see where the errors are coming from. You can see that there are 6 errors if you scroll to the bottom. There are also a bunch of warnings, but I don't believe they are caused by your code, so they can be ignored. Lmk if you don't see them.

[bparrishMines]

Hi @DennisAlund, are you still working on this PR?

[DennisAlund]

Hey, I didn't have time to look into it yet. Would need to try it out with xcode since it is the objectivec code that is causing issues. But I haven't had a chance to do that. Would appreciate input from the community if there's someone who's got xcode and a bit of time.

[DennisAlund]

@bparrishMines the build issues were resolved with the most recent merge of master into my branch :-)

[bparrishMines]

Hi @DennisAlund,

Thanks for your contribution! Everything looks good! Just a few small things before I merge it.

[bparrishMines]

Thanks! I have a branch that will bump the version and this will get published with it.