Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter_web] Allow marker position updates #6753

Closed
wants to merge 1 commit into from

Conversation

AsturaPhoenix
Copy link

@AsturaPhoenix AsturaPhoenix commented Nov 24, 2022

Unconditionally convert the current marker position in convert.dart:_markerOptionsFromMarker, to allow for position updates.

Also adds position changes to marker_test.dart/MarkerController/update and markers_test.dart/MarkersController/changeMarkers. The MarkersController case is fixed by this patch.

Issue: flutter/flutter#83467

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Dec 1, 2022

Thanks for the contribution! Could you merge in the latest main? This is branched from a version older than the last update to our infrastructure tokens, so most of the CI is unable to run.

@AsturaPhoenix
Copy link
Author

Done; please let me know if further action is required from me. I'm not familiar with these tests, but the failing test looks like it can't find the compass button on iOS. I don't have an iOS test setup yet, and this change was limited to the web plugin.

Unconditionally convert the current marker position in `convert.dart:_markerOptionsFromMarker`, to allow for position updates.

Also adds position changes to `marker_test.dart/MarkerController/update` and `markers_test.dart/MarkersController/changeMarkers`. The `MarkersController` case is fixed by this patch.
@AsturaPhoenix
Copy link
Author

Looks like that test may have been reverted. Rebasing and rerunning.

@stuartmorgan-g
Copy link
Contributor

@ditman Ping on this review.

@Henk-Keijzer

This comment was marked as off-topic.

@stuartmorgan-g
Copy link
Contributor

We've just completed the migration of the plugin code to the flutter/packages repository, as described in https://flutter.dev/go/flutter-plugins-repo-migration, and this repository is now being archived. Unfortunately that means that all in-progress PRs here must be moved to flutter/packages.

Please see our instructions for an explanation of how to move your PR, and if you have any issues moving your PR please don't hesitate to reach out in the #hackers-ecosystem channel in Discord.

Our apologies that your PR was caught in this one-time transition. We're aware that it's disruptive in the short term, and appreciate your help in getting us to a better long-term state!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants