[webview_flutter] Fix typo #6650
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
the
p: webview_flutter
Hi, it looks like it is a private method (start with underline) so client can never touch it? |
|
Yes, but it is still changing code that is ran by the client and doesn't fall under any of the categories for an exception: https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version. This change is pretty trivial, so you could just update the |
|
@bparrishMines Oh yes, I did not realize it does not fall under any category (surprisingly), thanks for pointing out. |
bparrishMines
added
the
override: no versioning needed
There was a problem hiding this comment.
I did not realize it does not fall under any category (surprisingly)
The reason there's no exception category for "changes to runtime code that don't actually affect anything" is that in practice—since it would be entirely subject to human judgment—it would actually be "changes to runtime code that weren't intended to affect anything".
I've seen (and been the cause of) many examples over the years of changes that weren't expected to change anything, but actually did. Batching those with other changes undermines the
makes regressions easier to pinpoint
part of the policy's goals.
| @@ -5,6 +5,7 @@ | |||
| * Fixes avoid_redundant_argument_values lint warnings and minor typos. | |||
| * Ignores unnecessary import warnings in preparation for [upcoming Flutter changes](https://github.com/flutter/flutter/pull/104231). | |||
| * Updates references to the obsolete master branch. | |||
| * Fix typo from lowercase to uppercase | |||
There was a problem hiding this comment.
This needs to follow the changelog style guide linked from the PR description.
|
test-exemption: code refactor with no semantic change |
* 3ec3cc1e2 Add `Mac_x64 darwin_lint_podspecs` to LUCI (flutter/plugins#6637) * 0e5e90f6c [webview_flutter] Fix typo (flutter/plugins#6650) * f04ef7309 Roll Flutter from 55e8cd1 to e0e7027 (20 revisions) (flutter/plugins#6673) * 3ca34103d Roll Flutter from e0e7027 to 5ea5a53 (7 revisions) (flutter/plugins#6675)
* Update webview.dart * Update CHANGELOG.md * Update CHANGELOG.md
* Update webview.dart * Update CHANGELOG.md * Update CHANGELOG.md
…#114813) * 3ec3cc1e2 Add `Mac_x64 darwin_lint_podspecs` to LUCI (flutter/plugins#6637) * 0e5e90f6c [webview_flutter] Fix typo (flutter/plugins#6650) * f04ef7309 Roll Flutter from 55e8cd1 to e0e7027 (20 revisions) (flutter/plugins#6673) * 3ca34103d Roll Flutter from e0e7027 to 5ea5a53 (7 revisions) (flutter/plugins#6675)
…#114813) * 3ec3cc1e2 Add `Mac_x64 darwin_lint_podspecs` to LUCI (flutter/plugins#6637) * 0e5e90f6c [webview_flutter] Fix typo (flutter/plugins#6650) * f04ef7309 Roll Flutter from 55e8cd1 to e0e7027 (20 revisions) (flutter/plugins#6673) * 3ca34103d Roll Flutter from e0e7027 to 5ea5a53 (7 revisions) (flutter/plugins#6675)
* Update webview.dart * Update CHANGELOG.md * Update CHANGELOG.md
Just one char fix :) Realize this when reading through the code trying to fix a real bug
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.