Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Support updateEmail in firebase_auth #647

Merged
merged 6 commits into from
Jul 26, 2018

Conversation

thmsdnnr
Copy link
Contributor

@thmsdnnr thmsdnnr commented Jul 1, 2018

Updated firebase_auth plugin to expose updateEmail.

  • defines an updateEmail method on FirebaseAuth with a named email parameter
  • passes back exceptions, including failure to update if current user has not signed in recently e.g.:
PlatformException(Error 17014, FIRAuthErrorDomain, 
This operation is sensitive and requires recent authentication.
Log in again before retrying this request.)

Reference:

https://firebase.google.com/docs/auth/android/manage-users#set_a_users_email_address
https://firebase.google.com/docs/auth/ios/manage-users#set_a_users_email_address

Related Issues:

flutter/flutter#18959
flutter/flutter#17343

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@ashtonthomas
Copy link

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

👍

Confirming my commits, AUTHORS addition, and submission of CLA

@kroikie
Copy link
Contributor

kroikie commented Jul 23, 2018

@thmsdnnr There are currently some conflicts on this PR. Rebasing on master should resolve them. Looking forward to getting the PR in. Thanks.

@thmsdnnr thmsdnnr force-pushed the fire_auth_update_email branch from bb541b7 to 99b8e6e Compare July 25, 2018 12:24
@thmsdnnr
Copy link
Contributor Author

Hi @kroikie — sure thing! I rebased this on master this morning and bumped the patch version in the CHANGELOG and pubspec.

@ashtonthomas gave the OK when we initially submitted, since it's his repo we both worked on. I assume that's a manual confirmation on the CI checks. Please let us know if you need anything else.

@kroikie
Copy link
Contributor

kroikie commented Jul 25, 2018

@thmsdnnr Thanks for those updates, we had another update to this plugin which is now conflicting. Please resolve those small conflicts. I'll be happy to merge once they are in.

@thmsdnnr thmsdnnr force-pushed the fire_auth_update_email branch from 99b8e6e to 39d234e Compare July 25, 2018 16:01
@thmsdnnr
Copy link
Contributor Author

thmsdnnr commented Jul 25, 2018

@kroikie No problem! I rebased and bumped the pubspec version up to 0.5.18. It looks like a bunch of CI checks failed though, it looks like all linked to a Gradle issue:

* What went wrong:
A problem occurred evaluating project ':app'.
> Could not resolve all files for configuration 'classpath'.
   > Could not resolve com.android.tools.build:gradle-core:3.1.2.
     Required by:
         unspecified:unspecified:unspecified > com.android.tools.build:gradle:3.1.2
      > Could not resolve com.android.tools.build:gradle-core:3.1.2.
         > Could not get resource 'https://jcenter.bintray.com/com/android/tools/build/gradle-core/3.1.2/gradle-core-3.1.2.pom'.
            > Could not HEAD 'https://jcenter.bintray.com/com/android/tools/build/gradle-core/3.1.2/gradle-core-3.1.2.pom'.
               > Read timed out

(from the Travis CI logs)

How should I proceed?

@kroikie kroikie merged commit 433dc28 into flutter:master Jul 26, 2018
@thmsdnnr thmsdnnr deleted the fire_auth_update_email branch July 31, 2018 03:42
@saltpetre
Copy link

Hi any eta on when 0.5.18 will be available. It is still showing 0.5.15 on flutter plugin

@kroikie
Copy link
Contributor

kroikie commented Aug 10, 2018

@saltpetreca sorry for the delay, published.

@saltpetre
Copy link

saltpetre commented Aug 10, 2018 via email

julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
* add support for update email in firebase_auth
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants