-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
👍 Confirming my commits, |
@thmsdnnr There are currently some conflicts on this PR. Rebasing on master should resolve them. Looking forward to getting the PR in. Thanks. |
bb541b7
to
99b8e6e
Compare
Hi @kroikie — sure thing! I rebased this on master this morning and bumped the patch version in the CHANGELOG and pubspec. @ashtonthomas gave the OK when we initially submitted, since it's his repo we both worked on. I assume that's a manual confirmation on the CI checks. Please let us know if you need anything else. |
@thmsdnnr Thanks for those updates, we had another update to this plugin which is now conflicting. Please resolve those small conflicts. I'll be happy to merge once they are in. |
99b8e6e
to
39d234e
Compare
@kroikie No problem! I rebased and bumped the pubspec version up to 0.5.18. It looks like a bunch of CI checks failed though, it looks like all linked to a Gradle issue:
How should I proceed? |
Hi any eta on when 0.5.18 will be available. It is still showing 0.5.15 on flutter plugin |
@saltpetreca sorry for the delay, published. |
Super thanks!
On Aug 10, 2018, at 12:21 PM, Arthur Thompson <notifications@github.com> wrote:
@saltpetreca sorry for the delay, published.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
* add support for update email in firebase_auth
Updated firebase_auth plugin to expose updateEmail.
Reference:
https://firebase.google.com/docs/auth/android/manage-users#set_a_users_email_address
https://firebase.google.com/docs/auth/ios/manage-users#set_a_users_email_address
Related Issues:
flutter/flutter#18959
flutter/flutter#17343