Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@GaryQian
Copy link
Contributor

Based off of #6132 by @tosaka07

Added IMMEDIATE_AND_CHARGE_FULL_PRICE to ProrationMode.

IMMEDIATE_AND_CHARGE_FULL_PRICE is new in Billing Library v4.
https://developer.android.com/google/play/billing/release-notes#4-0-0-summary-changes

This library has already been updated to v5, so there is no problem.

Fixes flutter/flutter#108164

@GaryQian GaryQian changed the title [in_app_purchase] Add immediateAndChargeFullPrice [in_app_purchase] Add immediateAndChargeFullPrice ProrationMode Sep 12, 2022
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

## 0.2.3+4

* Updates minimum Flutter version to 2.10.
Adds IMMEDIATE_AND_CHARGE_FULL_PRICE to the ProrationMode.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: needs a bullet.

## 0.2.3+4

* Updates minimum Flutter version to 2.10.
Adds IMMEDIATE_AND_CHARGE_FULL_PRICE to the ProrationMode.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:`ProrationMode`

immediateWithoutProration,

/// Replacement takes effect when the old plan expires, and the new price will be charged at the same time.
/// Replacement takes effect when the old plan expires, and the new price will
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has trailing whitespace that is making format sad.

@GaryQian GaryQian added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 13, 2022
@auto-submit auto-submit bot merged commit 5e7c779 into flutter:main Sep 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 14, 2022
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 3, 2022
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: in_app_purchase platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[in_app_purchase][android] Add IMMEDIATE_AND_CHARGE_FULL_PRICE to ProrationMode

2 participants