This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[path_provider] Update win32 #6352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
suggested changes
Sep 2, 2022
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
I'm having a hard time understanding the rationale for bumping the minimum version here.
Can you provide a bit more detail on why this is necessary?
stuartmorgan-g
suggested changes
Sep 2, 2022
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Some comments inline below.
cbracken
reviewed
Sep 2, 2022
Contributor
Author
|
@stuartmorgan @cbracken Done |
This was referenced Sep 2, 2022
stuartmorgan-g
suggested changes
Sep 2, 2022
stuartmorgan-g
suggested changes
Sep 2, 2022
stuartmorgan-g
approved these changes
Sep 2, 2022
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM (I made a small style fix since the verb form didn't match our style).
Contributor
|
@cbracken for secondary review. |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 8, 2022
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 3, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
This PR updates the
win32dependency to3.0.0to avoid current and future version conflicts.List which issues are fixed by this PR. You must list at least one issue.
ThexXTURBOXx/flutter_web_auth_2#6
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.