Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update docs to reflect field paths separated by '.' #629

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Update docs to reflect field paths separated by '.' #629

merged 1 commit into from
Jul 26, 2018

Conversation

slightfoot
Copy link
Member

No description provided.

@slightfoot slightfoot mentioned this pull request Jun 20, 2018
Closed
kroikie
kroikie previously requested changes Jun 20, 2018
View reviewed changes
packages/cloud_firestore/lib/src/query.dart Outdated
///
/// The [field] may consist of a single field name (referring to a top level
/// field in the document), or a series of field names seperated by
/// forward-slashes '.' (referring to a nested field in the document).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you mean separated by dots?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected.

@kroikie kroikie self-assigned this Jun 20, 2018
@slightfoot
Copy link
Member Author

Thanks @kroikie that was embarrassing. Correction commited. Just waiting on the checks.

@kroikie
Copy link
Contributor

kroikie commented Jun 20, 2018

@slightfoot Thanks for this PR, could you also bump the version number then update the CHANGELOG so I can publish it and get the updated docs into our generated documentation.

@slightfoot
Copy link
Member Author

@kroikie version bumped to v0.7.4 and CHANGELOG updated. Just waiting on checks. Cheers.

@Hixie
Copy link
Contributor

Hixie commented Jun 26, 2018

@kroikie Can you see why the tests are failing?

@Hixie Hixie dismissed kroikie’s stale review July 17, 2018 23:57

comments addressed

@kroikie
Copy link
Contributor

kroikie commented Jul 19, 2018

@slightfoot would you please rebase this PR, tests should pass then.

@slightfoot
Copy link
Member Author

@kroikie Squashed and rebased onto master. I've removed the changelog as it conflicted and it's such a minor change it can go in any reason without specific changelog entry.

@kroikie
Copy link
Contributor

kroikie commented Jul 23, 2018

@slightfoot sorry there seems to still be some formatting issues. Could you resolve those then I'll merge?

@slightfoot
Copy link
Member Author

@kroikie The formatting changes that are an issue are not from my commits. Someone else has merged without dartfmt on master before my commits. What do you want to do?

packages/google_maps_flutter/example/lib/map_ui.dart
packages/google_sign_in/lib/widgets.dart
packages/path_provider/example/lib/main.dart
packages/shared_preferences/example/lib/main.dart

@kroikie
Copy link
Contributor

kroikie commented Jul 23, 2018

@slightfoot You are correct, the formatting issues are not on your end at all. Once you rebase those changes should no longer be part of your PR.

@slightfoot
Copy link
Member Author

@kroikie rebased.

@kroikie kroikie merged commit 413873a into flutter:master Jul 26, 2018
@slightfoot slightfoot deleted the firestore_fieldpath branch September 6, 2018 23:41
@Hixie Hixie removed the needs love label Oct 24, 2018
@zoechi zoechi mentioned this pull request Dec 23, 2018
Closed
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
@slightfoot @kroikie
Update docs to reflect field paths separated by '.' (flutter#629)
217b6f2 
Firestore doc update.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kroikie kroikie kroikie left review comments

Assignees

@kroikie kroikie

Labels
cla: yes flutterfire
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slightfoot @kroikie @Hixie @googlebot