This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Prepare for fix to https://github.com/flutter/flutter/issues/109339. #6278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, in some circumstances where a subclasses of `PlatformInterface` erroneously uses `implements` rather than `extends`, a `NoSuchMethodError` will be thrown (in spite of the documentation at https://pub.dev/documentation/plugin_platform_interface/latest/plugin_platform_interface/PlatformInterface/verify.html claiming that `AssertionError` will be thrown). After flutter/flutter#109339 is fixed, the correct type of exception will be thrown. To avoid tests breakages when the fix happens, we need to modify these tests so that they don't care what kind of exception is thrown.
stereotype441
requested review from
bparrishMines and
stuartmorgan-g
as code owners
github-actions
bot
added
p: camera
p: google_maps_flutter
p: google_sign_in
p: in_app_purchase
p: quick_actions
p: url_launcher
p: webview_flutter
bparrishMines
approved these changes
Aug 16, 2022
The heuristics know that here since it's test-only, so we only need to override the changelog check. |
stuartmorgan-g
added
the
override: no changelog needed
stereotype441
added
override: no versioning needed
stuartmorgan-g
suggested changes
Aug 16, 2022
...s/in_app_purchase/in_app_purchase_platform_interface/test/in_app_purchase_platform_test.dart
Outdated
Show resolved
Hide resolved
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 17, 2022
camsim99
pushed a commit
to camsim99/plugins
that referenced
this pull request
Aug 23, 2022
Currently, in some circumstances where a subclasses of `PlatformInterface` erroneously uses `implements` rather than `extends`, a `NoSuchMethodError` will be thrown (in spite of the documentation at https://pub.dev/documentation/plugin_platform_interface/latest/plugin_platform_interface/PlatformInterface/verify.html claiming that `AssertionError` will be thrown). After flutter/flutter#109339 is fixed, the correct type of exception will be thrown. To avoid tests breakages when the fix happens, we need to modify these tests so that they don't care what kind of exception is thrown.
moisefeelin
pushed a commit
to feelinproject/plugins
that referenced
this pull request
Aug 26, 2022
Currently, in some circumstances where a subclasses of `PlatformInterface` erroneously uses `implements` rather than `extends`, a `NoSuchMethodError` will be thrown (in spite of the documentation at https://pub.dev/documentation/plugin_platform_interface/latest/plugin_platform_interface/PlatformInterface/verify.html claiming that `AssertionError` will be thrown). After flutter/flutter#109339 is fixed, the correct type of exception will be thrown. To avoid tests breakages when the fix happens, we need to modify these tests so that they don't care what kind of exception is thrown.
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
Currently, in some circumstances where a subclasses of `PlatformInterface` erroneously uses `implements` rather than `extends`, a `NoSuchMethodError` will be thrown (in spite of the documentation at https://pub.dev/documentation/plugin_platform_interface/latest/plugin_platform_interface/PlatformInterface/verify.html claiming that `AssertionError` will be thrown). After flutter/flutter#109339 is fixed, the correct type of exception will be thrown. To avoid tests breakages when the fix happens, we need to modify these tests so that they don't care what kind of exception is thrown.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in some circumstances where a subclasses of
PlatformInterfaceerroneously usesimplementsrather thanextends, aNoSuchMethodErrorwill be thrown (in spite of thedocumentation at
https://pub.dev/documentation/plugin_platform_interface/latest/plugin_platform_interface/PlatformInterface/verify.html
claiming that
AssertionErrorwill be thrown).After flutter/flutter#109339 is fixed, the
correct type of exception will be thrown. To avoid tests breakages
when the fix happens, we need to modify these tests so that they don't
care what kind of exception is thrown.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.