Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[path_provider] Revert Gradle and androidx.annotation bump in path_provider_android #6231

Merged
merged 4 commits into from
Aug 12, 2022

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Aug 12, 2022

Reverts #6189 and #6228 to fix flutter/flutter#109397.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…/path_provider/path_provider_android/android (flutter#6189)"

This reverts commit e9d8479.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@camsim99 camsim99 changed the title Revert Gradle and androidx.annotation bump in path_provider_android [path_provider] Revert Gradle and androidx.annotation bump in path_provider_android Aug 12, 2022
@@ -2,7 +2,7 @@ name: path_provider_android
description: Android implementation of the path_provider plugin.
repository: https://github.com/flutter/plugins/tree/main/packages/path_provider/path_provider_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+path_provider%22
version: 2.0.19
version: 2.0.18

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we already published 2.0.19, I think we'll have to name this 2.0.20

@christopherfujino
Copy link

should we also roll back Gary's Kotlin change in #6228 ?

@camsim99
Copy link
Contributor Author

should we also roll back Gary's Kotlin change in #6228 ?

I asked @GaryQian and he thought it would be safe to keep it. I don't have much context on the impact of the change, so I'd be fine reverting it just in case.

@GaryQian
Copy link
Contributor

You can roll kotlin back too just in case. It's super easy to bump it again, let's green the tree first

@christopherfujino
Copy link

You can roll kotlin back too just in case. It's super easy to bump it again, let's green the tree first

The tree is green now because I pinned path_provider_android to 2.0.17. If we can validate this change works on the affected devicelab build, we can un-pin the package and the bot will roll it forward.

Copy link
Contributor

@GaryQian GaryQian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


* Bumps kotlin to 1.7.10

## 2.0.18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to be removing changelog history. It's sufficient to just keep bumping forwards.

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 12, 2022
@auto-submit auto-submit bot merged commit 16297e3 into flutter:main Aug 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2022
moisefeelin pushed a commit to feelinproject/plugins that referenced this pull request Aug 26, 2022
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests p: path_provider platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade of package:path_provider_android broke flutter_engine_group_performance test
3 participants