-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[path_provider] Revert Gradle and androidx.annotation bump in path_provider_android #6231
Conversation
…/path_provider/path_provider_android/android (flutter#6189)" This reverts commit e9d8479.
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
@@ -2,7 +2,7 @@ name: path_provider_android | |||
description: Android implementation of the path_provider plugin. | |||
repository: https://github.com/flutter/plugins/tree/main/packages/path_provider/path_provider_android | |||
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+path_provider%22 | |||
version: 2.0.19 | |||
version: 2.0.18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we already published 2.0.19, I think we'll have to name this 2.0.20
should we also roll back Gary's Kotlin change in #6228 ? |
You can roll kotlin back too just in case. It's super easy to bump it again, let's green the tree first |
The tree is green now because I pinned path_provider_android to 2.0.17. If we can validate this change works on the affected devicelab build, we can un-pin the package and the bot will roll it forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
||
* Bumps kotlin to 1.7.10 | ||
|
||
## 2.0.18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to be removing changelog history. It's sufficient to just keep bumping forwards.
…in path_provider_android (flutter/plugins#6231)
Reverts #6189 and #6228 to fix flutter/flutter#109397.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.