Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter_web] Pass BitmapDescriptor.fromBytes size to JS SDK (2/2) #6209

Merged
merged 6 commits into from
Aug 17, 2022

Conversation

ditman
Copy link
Member

@ditman ditman commented Aug 5, 2022

Updates conversion of BitmapDescriptor.fromBytes marker icons to support the new size parameter.

Also:

  • Minor refactor to extract the conversion of BitmapDescriptor to gm.Icon to a separate method.
  • Updates test mocks to the ones generated by the currently selected version of Mockito (5.3.0)

Issues

Tests

Needs one final rebase

  • This will fail several checks (publishable at least?) until the platform_interface PR listed above lands. Feel free to skip the code in the platform_interface package from this PR.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman requested a review from stuartmorgan-g as a code owner August 5, 2022 04:18
@ditman ditman changed the title [google_maps_flutter_web] Pass BitmapDescriptor.fromBytes size to JS SDK [google_maps_flutter_web] Pass BitmapDescriptor.fromBytes size to JS SDK (2/2) Aug 5, 2022
@ditman ditman force-pushed the pass-size-to-maps-js-sdk branch from 9f8fc64 to 0faca95 Compare August 5, 2022 04:21
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2022
@ditman
Copy link
Member Author

ditman commented Aug 17, 2022

Thanks for taking care of this one @stuartmorgan, I've added the autosubmit label so it lands whenever. 🙏

@auto-submit auto-submit bot merged commit 9bb6771 into flutter:main Aug 17, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 17, 2022
camsim99 pushed a commit to camsim99/plugins that referenced this pull request Aug 23, 2022
moisefeelin pushed a commit to feelinproject/plugins that referenced this pull request Aug 26, 2022
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: google_maps_flutter platform-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_maps_flutter_web marker too big
2 participants