Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase_storekit] Add identifier, type fields to SKProductDiscountWrapper #6205

Merged
merged 17 commits into from
Aug 10, 2022

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Aug 4, 2022

SKProductDiscount added "identifier", "type" two fields in iOS12.2, but the plugin is missing.
In some discount purchase scenarios, we need these fields.

Fixes flutter/flutter#100602

This PR is a fork of #5102
On top of the original PR, the version is updated to 0.3.2 instead of 0.3.1.

See #5102 (comment) for why the original PR is forked.

cc @fengyuxx

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The native side LGTM, I'm not really familiar how the dart wrappers work though.

@jmagman
Copy link
Member

jmagman commented Aug 10, 2022

@cyanglaz points out this was already reviewed in #5102, this LGTM.

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 10, 2022
@auto-submit auto-submit bot merged commit 6c9738e into flutter:main Aug 10, 2022
@cyanglaz cyanglaz deleted the 5102 branch August 10, 2022 21:10
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 11, 2022
yutaaraki-toydium pushed a commit to yutaaraki-toydium/plugins that referenced this pull request Aug 12, 2022
moisefeelin pushed a commit to feelinproject/plugins that referenced this pull request Aug 26, 2022
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: in_app_purchase platform-ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[in_app_purchase] SKProductDiscount added "identifier", "type" two fields in iOS12.2
3 participants