Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker_android] bump dependency version of package:image_picker_platform_interface #6202

Closed
wants to merge 2 commits into from

Conversation

CicadaCinema
Copy link
Contributor

The usage

ImagePickerOptions options = const ImagePickerOptions(),
of the ImagePickerOptions class stipulates at least v2.5.0 of package:image_picker_platform_interface

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@stuartmorgan-g
Copy link
Contributor

Thanks for the submission! I filed flutter/flutter#108992 which I'll try to get to shortly, which would give us testing that would catch these kinds of issues. I'll come back to this once that's in place, since it would give this test coverage (which isn't strictly necessary here, but would be good).

@stuartmorgan-g
Copy link
Contributor

Closing as obsoleted by #6207 (I forgot I would need to fix the violations in the PR that added the testing).

Thanks again for highlighting the systemic issue here!

@CicadaCinema CicadaCinema deleted the patch-1 branch September 26, 2022 13:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants