This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Uncomments avoid_redundant_argument_values in analysis_options.yaml #6163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofirazak
requested review from
GaryQian,
bparrishMines,
camsim99,
cbracken,
cyanglaz,
ditman,
gaaclarke,
hellohuanlin and
stuartmorgan-g
as code owners
github-actions
bot
added
p: camera
p: file_selector
p: google_maps_flutter
p: google_sign_in
p: image_picker
p: in_app_purchase
p: local_auth
p: path_provider
p: url_launcher
p: video_player
p: webview_flutter
bparrishMines
suggested changes
Aug 3, 2022
Contributor
bparrishMines
left a comment
bparrishMines
left a comment
There was a problem hiding this comment.
Thanks for working on this!
Mostly looks good, just a few comments.
packages/camera/camera_web/example/integration_test/camera_service_test.dart
Show resolved
Hide resolved
packages/camera/camera_web/example/integration_test/camera_web_test.dart
Show resolved
Hide resolved
...es/google_maps_flutter/google_maps_flutter_web/example/integration_test/projection_test.dart
Show resolved
Hide resolved
packages/in_app_purchase/in_app_purchase_android/example/lib/main.dart
Outdated
Show resolved
Hide resolved
stuartmorgan-g
suggested changes
Aug 4, 2022
packages/camera/camera_web/example/integration_test/camera_service_test.dart
Show resolved
Hide resolved
# Conflicts: # packages/camera/camera_windows/CHANGELOG.md # packages/camera/camera_windows/pubspec.yaml
Contributor
Author
|
fixed all the requested changes |
stuartmorgan-g
approved these changes
Aug 8, 2022
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
A few minor nits, but otherwise LGTM!
packages/in_app_purchase/in_app_purchase_android/example/lib/main.dart
Outdated
Show resolved
Hide resolved
packages/in_app_purchase/in_app_purchase_android/example/lib/main.dart
Outdated
Show resolved
Hide resolved
packages/in_app_purchase/in_app_purchase_android/example/lib/main.dart
Outdated
Show resolved
Hide resolved
packages/in_app_purchase/in_app_purchase_storekit/example/lib/main.dart
Outdated
Show resolved
Hide resolved
# Conflicts: # packages/local_auth/local_auth_android/CHANGELOG.md # packages/local_auth/local_auth_ios/CHANGELOG.md # packages/local_auth/local_auth_windows/CHANGELOG.md # packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md
Contributor
Author
|
@bparrishMines |
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2022
yutaaraki-toydium
pushed a commit
to yutaaraki-toydium/plugins
that referenced
this pull request
Aug 12, 2022
moisefeelin
pushed a commit
to feelinproject/plugins
that referenced
this pull request
Aug 26, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables avoid_redundant_argument_values lint and fixes all related violations in all plugins.
Part of flutter/flutter#76229
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).