This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[video_player] Rename internal method channels#5045
Merged
fluttergithubbot merged 2 commits intoflutter:mainfrom Mar 15, 2022
Merged
[video_player] Rename internal method channels#5045fluttergithubbot merged 2 commits intoflutter:mainfrom
fluttergithubbot merged 2 commits intoflutter:mainfrom
Conversation
Currently the internal Pigeon API definitions use the same class name as the legacy shared method channel, which should no longer be used. This means that if someone accidentally uses the shared implementation on the Dart side somehow, they will get crashes instead of "no handler registered" message (see flutter/flutter#99946) This renames the API classes for the internal Android and iOS implementations to avoid collisions in the method channel names. Also updates to the latest version of Pigeon, which picks up minor recent changes.
gaaclarke
approved these changes
Mar 14, 2022
stuartmorgan-g
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the internal Pigeon API definitions use the same class name as
the legacy shared method channel (which should no longer be used). This
means that if someone accidentally uses the shared implementation on the
Dart side somehow, they will get crashes instead of "no handler
registered" messages (see
flutter/flutter#99946)
This renames the API classes for the internal Android and iOS
implementations to avoid collisions in the method channel names.
Also updates to the latest version of Pigeon, which picks up minor
recent changes.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).