Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[local_auth] Move local_auth plugin into a subfolder in preparation for federation migration #4705

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

BeMacized
Copy link
Contributor

This PR is a precursor to upcoming PRs for migrating the local_auth plugin to a federated architecture.

This PR only moves the local_auth plugin to a subfolder to make room for the native and platform interface packages.

Relevant issues:

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
    • Not needed, is not a new release. No code has been changed.
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
    • Not needed, is not a new release. No code has been changed.
  • I updated/added relevant documentation (doc comments with ///).
    • Not needed, is not a new release. No code has been changed.
  • I added new tests to check the change I am making, or this PR is [test-exempt].
    • Not needed, is not a new release. No code has been changed.
  • All existing and new tests are passing.

Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BeMacized BeMacized added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jan 27, 2022
@BeMacized BeMacized merged commit c27b257 into flutter:main Jan 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p: local_auth platform-android platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants