[file_selector] Endorse Windows #4696
Conversation
Adds file_selector_windows as an endorsed implementation, and enables the example to build for Windows. The code in example/ is the template-generated code, unchanged except for adding the license and autoformatting it with repository settings. Part of flutter/flutter#70221
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
stuartmorgan-g
added
waiting for tree to go green
| web: | ||
| default_package: file_selector_web | ||
| windows: | ||
| default_package: file_selector_windows |
There was a problem hiding this comment.
Weirdest platform support of all Flutter plugins. I love it!
Thanks for bringing this over, congrats on the merge! 👏
There was a problem hiding this comment.
If only we'd started with the Windows implementation, we could have slowly added them in reverse alphabetical order.
* use path_provider_macos on only test * remove redundant dev deps * file_selector_macos and file_selector_windows has been endorsed. See: flutter/plugins#5001 and flutter/plugins#4696 * meta package is contained in Dart SDK * analyzer * add meta on dev_deps * rever meta package change
Adds file_selector_windows as an endorsed implementation, and enables
the example to build for Windows.
The code in example/ is the template-generated code, unchanged except
for adding the license and autoformatting it with repository settings.
Part of flutter/flutter#70221
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).