This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[plugin_platform_interface] Test that PlatformInterface and MockPlatformInterfaceMixinTest have no instance methods
#4659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinjackson
force-pushed
the
static-methods-only
branch
4 times, most recently
from
81f45c3 to
9de8e26
Compare
collinjackson
changed the title
PlatformInterface has no instance methods
kevmoo
approved these changes
Jan 10, 2022
collinjackson
changed the title
collinjackson
force-pushed
the
static-methods-only
branch
from
61deea1 to
08842d0
Compare
collinjackson
changed the title
stuartmorgan
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
Great idea, LGTM!
No version change: I am not sure that this change is worth releasing an update for, so I've marked it as NEXT, but reviewers, let me know if you'd like to see this be a minor or patch update.
FYI the final version of this doesn't need this annotation; because the only change is to tests, the check wouldn't have flagged it.
collinjackson
changed the title
PlatformInterface has no instance methods
collinjackson
added
the
waiting for tree to go green
collinjackson
force-pushed
the
static-methods-only
branch
from
32b0cd9 to
3fe9fbb
Compare
collinjackson
changed the title
PlatformInterface has no instance methodsPlatformInterface and StaticMethodsOnlyMockPlatformInterfaceMixinTest have no instance methods
collinjackson
changed the title
PlatformInterface and StaticMethodsOnlyMockPlatformInterfaceMixinTest have no instance methodsPlatformInterface and MockPlatformInterfaceMixinTest have no instance methods
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
stuartmorgan
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
stuartmorgan
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 20, 2022
… `MockPlatformInterfaceMixinTest` have no instance methods (flutter/plugins#4659)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlatformInterfaceandMockPlatformInterfaceMixinTesthave no instance methods with a comment explaining why doing so is a breaking change.No version change: As a test-only change, it is not necessary to release as an update to pub, so I've marked it as NEXT.
Follow-on PR to flutter/flutter#96178
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).