-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[url_launcher] Fix minor memory leak in Linux url-launcher tests #4648
[url_launcher] Fix minor memory leak in Linux url-launcher tests #4648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! Thanks for the fix, LG other than needing a CHAGELOG update (using ## NEXT
) to make publishable
happy.
@stuartmorgan I updated the description to avoid the need for a CHANGELOG entry - should I add one for a change like this? |
The policy we'd settled on for now is to generally require a CHANGELOG even for non-production changes because it's convenient for us to see what changed (especially since occasionally we make changes we think aren't production-affecting but were wrong, although obviously that wouldn't apply here). We may revisit if it's annoying after living with it for a while. I'm fine with not having one here, but you'll need to push something to get |
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to master. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick. |
2e67266
to
bf59489
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix minor memory leak in Linux url-launcher tests
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.md
to add a description of the change, [following repository CHANGELOG style].///
).