Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Fix version and CHANGELOG #4513

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

stuartmorgan-g
Copy link
Contributor

#4423 incorrectly added changelog
entries to an already-published version instead of bumping the version,
whcih was missed during review.

This moves those entries to a new version, so that they will be a) published
and b) associated with the correct version in the CHANGELOG.

Fixes flutter/flutter#93659

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

flutter#4423 incorrectly added changelog
entries to an already-published version instead of bumping the version,
whcih was missed during review.

Fixes flutter/flutter#93659
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for correcting this!

@stuartmorgan-g
Copy link
Contributor Author

No problem, I should have noticed it in review.

@stuartmorgan-g stuartmorgan-g merged commit b6e8d05 into flutter:master Nov 15, 2021
@stuartmorgan-g stuartmorgan-g deleted the camera-version-fix branch November 15, 2021 20:31
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 16, 2021
henri-henri pushed a commit to sofcograhapt/plugins that referenced this pull request Nov 29, 2021
flutter#4423 incorrectly added changelog
entries to an already-published version instead of bumping the version,
whcih was missed during review.

Fixes flutter/flutter#93659

(cherry picked from commit b6e8d05)
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
flutter#4423 incorrectly added changelog
entries to an already-published version instead of bumping the version,
whcih was missed during review.

Fixes flutter/flutter#93659
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
flutter#4423 incorrectly added changelog
entries to an already-published version instead of bumping the version,
whcih was missed during review.

Fixes flutter/flutter#93659
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[camera] Not all deprecation warnings on compile SDK 31 have been fixed
2 participants