-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Bring up new Windows test targets #4311
Changes from 1 commit
a057885
a050e41
089d127
46e1b79
cea3b78
f2e69d5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,6 +35,7 @@ platform_properties: | |
os: Windows | ||
|
||
targets: | ||
# TODO(stuartmorgan) Remove once the renamed version below has propagated. | ||
- name: Windows Plugins master channel | ||
recipe: plugins/plugins | ||
timeout: 30 | ||
|
@@ -47,6 +48,7 @@ targets: | |
] | ||
scheduler: luci | ||
|
||
# TODO(stuartmorgan) Remove once the renamed version below has propagated. | ||
- name: Windows Plugins stable channel | ||
recipe: plugins/plugins | ||
timeout: 30 | ||
|
@@ -60,6 +62,88 @@ targets: | |
] | ||
scheduler: luci | ||
|
||
- name: windows-build+platform-tests master | ||
recipe: plugins/plugins | ||
bringup: true | ||
timeout: 30 | ||
properties: | ||
# TODO(stuartmorgan): Uncomment when removing bringup. | ||
#add_recipes_cq: "true" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this necessary? My expectation is this could land in this PR There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably not for this particular one since it's a copy-paste, but in general I would rather make sure a new target actually works in the wild before adding it to the recipe CQ since I really don't want to bring the recipes repo to a standstill by throwing untested things into its pipeline for landing changes. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a really good insight! I'll have to add it to the documentation (and later as a test) |
||
target_file: windows_build_and_platform_tests.yaml | ||
dependencies: > | ||
[ | ||
{"dependency": "vs_build"} | ||
] | ||
scheduler: luci | ||
|
||
- name: windows-build+platform-tests stable | ||
recipe: plugins/plugins | ||
bringup: true | ||
timeout: 30 | ||
properties: | ||
# TODO(stuartmorgan): Uncomment when removing bringup. | ||
#add_recipes_cq: "true" | ||
target_file: uwp_build_and_platform_tests.yaml | ||
channel: stable | ||
dependencies: > | ||
[ | ||
{"dependency": "vs_build"} | ||
] | ||
scheduler: luci | ||
|
||
- name: build_all_plugins_windows master | ||
recipe: plugins/plugins | ||
bringup: true | ||
timeout: 30 | ||
properties: | ||
# TODO(stuartmorgan): Uncomment when removing bringup. | ||
#add_recipes_cq: "true" | ||
target_file: build_all_plugins.yaml | ||
dependencies: > | ||
[ | ||
{"dependency": "vs_build"} | ||
] | ||
scheduler: luci | ||
|
||
- name: build_all_plugins_windows stable | ||
recipe: plugins/plugins | ||
bringup: true | ||
timeout: 30 | ||
properties: | ||
# TODO(stuartmorgan): Uncomment when removing bringup. | ||
#add_recipes_cq: "true" | ||
target_file: build_all_plugins.yaml | ||
channel: stable | ||
dependencies: > | ||
[ | ||
{"dependency": "vs_build"} | ||
] | ||
scheduler: luci | ||
|
||
- name: uwp-build+platform-tests master | ||
recipe: plugins/plugins | ||
bringup: true | ||
timeout: 30 | ||
properties: | ||
# TODO(stuartmorgan): Uncomment when removing bringup. | ||
#add_recipes_cq: "true" | ||
target_file: uwp_build_and_platform_tests.yaml | ||
dependencies: > | ||
[ | ||
{"dependency": "vs_build"} | ||
] | ||
scheduler: luci | ||
|
||
- name: plugin_tools_tests - Windows | ||
recipe: plugins/plugins | ||
bringup: true | ||
timeout: 30 | ||
properties: | ||
# TODO(stuartmorgan): Uncomment when removing bringup. | ||
#add_recipes_cq: "true" | ||
target_file: plugin_tools_tests.yaml | ||
scheduler: luci | ||
|
||
- name: Linux ci_yaml plugins roller | ||
recipe: infra/ci_yaml | ||
timeout: 30 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
#!/bin/bash | ||
# Copyright 2013 The Flutter Authors. All rights reserved. | ||
# Use of this source code is governed by a BSD-style license that can be | ||
# found in the LICENSE file. | ||
|
||
cd all_plugins | ||
flutter build windows --debug | ||
flutter build windows --release |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
#!/bin/bash | ||
# Copyright 2013 The Flutter Authors. All rights reserved. | ||
# Use of this source code is governed by a BSD-style license that can be | ||
# found in the LICENSE file. | ||
|
||
dart ./script/tool/bin/flutter_plugin_tools.dart build-examples --winuwp \ | ||
--packages-for-branch |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
#!/bin/bash | ||
# Copyright 2013 The Flutter Authors. All rights reserved. | ||
# Use of this source code is governed by a BSD-style license that can be | ||
# found in the LICENSE file. | ||
|
||
dart ./script/tool/bin/flutter_plugin_tools.dart all-plugins-app \ | ||
--output-dir=. --exclude script/configs/exclude_all_plugins_app.yaml |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
#!/bin/bash | ||
# Copyright 2013 The Flutter Authors. All rights reserved. | ||
# Use of this source code is governed by a BSD-style license that can be | ||
# found in the LICENSE file. | ||
|
||
dart ./script/tool/bin/flutter_plugin_tools.dart native-test --windows \ | ||
--no-integration --packages-for-branch |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
#!/bin/bash | ||
# Copyright 2013 The Flutter Authors. All rights reserved. | ||
# Use of this source code is governed by a BSD-style license that can be | ||
# found in the LICENSE file. | ||
|
||
cd script/tool | ||
dart pub run test |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
tasks: | ||
- name: "prepare tool" | ||
script: .ci/scripts/prepare_tool.sh | ||
- name: "create all_plugins app" | ||
script: .ci/scripts/create_all_plugins_app.sh | ||
- name: "build all_plugins" | ||
script: .ci/scripts/build_all_plugins.sh |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
tasks: | ||
- name: "prepare tool" | ||
script: .ci/scripts/prepare_tool.sh | ||
- name: "tool unit tests" | ||
script: .ci/scripts/plugin_tools_tests.sh |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
tasks: | ||
- name: "prepare tool" | ||
script: .ci/scripts/prepare_tool.sh | ||
- name: "build examples (UWP)" | ||
script: .ci/scripts/build_examples_uwp.sh |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,9 @@ | ||
|
||
tasks: | ||
- name: "prepare tool" | ||
script: .ci/scripts/prepare_tool.sh | ||
- name: "build examples" | ||
- name: "build examples (Win32)" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think these target yaml files need strings around the name There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed. |
||
script: .ci/scripts/build_examples_win32.sh | ||
- name: "drive examples" | ||
- name: "native unit tests (Win32)" | ||
script: .ci/scripts/native_test_win32.sh | ||
- name: "drive examples (Win32)" | ||
script: .ci/scripts/drive_examples_win32.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
target names must follow the format $platform $name
So
Windows build+platform-tests master
. I'll send a PR to update this in the CI_YAML.mdThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.