Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[multiple_web] Update web plugin testing instructions. #4167

Merged
merged 2 commits into from
Jul 19, 2021
Merged

[multiple_web] Update web plugin testing instructions. #4167

merged 2 commits into from
Jul 19, 2021

Conversation

NishantChandla
Copy link
Contributor

@NishantChandla NishantChandla commented Jul 19, 2021 •
edited by ditman
Loading

Updated web testing instructions in example/README.md for web plugins. Latest web-test instructions point to https://github.com/flutter/flutter/wiki/Plugin-Tests#web-tests.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

@google-cla google-cla bot added the cla: yes label Jul 19, 2021
ditman
ditman suggested changes Jul 19, 2021
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove the "hardcoded" documentation about Mocks in url_launcher_web and google_maps_flutter_web, and point people to the flutter wiki as well. I've left a small example markdown that should work!

And thanks for your contribution!

@NishantChandla NishantChandla requested a review from ditman July 19, 2021 19:42
ditman
ditman approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, I'll have this merged ASAP!

@ditman ditman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jul 19, 2021
@NishantChandla
Copy link
Contributor Author

Looking great, I'll have this merged ASAP!

Thank You! @ditman

@ditman ditman changed the title Update web testing readme instructions [multiple_web] Update web plugin testing instructions. Jul 19, 2021
@fluttergithubbot fluttergithubbot merged commit 027db90 into flutter:master Jul 19, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 19, 2021
@engine-flutter-autoroll
027db90 [multiple_web] Update web plugin testing instructions. (flutt…
a2ae645 
…er/plugins#4167)
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Jul 19, 2021
@engine-flutter-autoroll
027db90 [multiple_web] Update web plugin testing instructions. (flutt…
38c2af6 
…er/plugins#4167) (#86681)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@NishantChandla @fotiDim
[multiple_web] Update web plugin testing instructions. (flutter#4167)
8d1e7c2
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@NishantChandla @amantoux
[multiple_web] Update web plugin testing instructions. (flutter#4167)
8ff65f2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ditman ditman ditman approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

Assignees
No one assigned
Labels
cla: yes p: connectivity p: file_selector p: google_maps_flutter p: google_sign_in p: url_launcher p: video_player platform-web waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[plugins] Update example/README.md of web plugins to point to the Flutter Wiki docs.
3 participants
@NishantChandla @ditman @fluttergithubbot