-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[in_app_purchase]Update the version number and CHANGELOG #4097
[in_app_purchase]Update the version number and CHANGELOG #4097
Conversation
In general I would recommend making the changelog and version changes in the PRs that land the changes, just in case something happens between one commit landing and the changelog commit landing. |
@Hixie, in this case the changes are made in the dependencies:
...
in_app_purchase_android: ^0.1.5
in_app_purchase_ios: ^0.1.3+5 Since the changes in #4094 and #4095 are breaking changes respectively the I will make sure that this will move forward as I am also working on moving #4094 and #4095 forward. |
…app_facing_add_cancel_status
@@ -1,3 +1,8 @@ | |||
## 2.0.0 | |||
|
|||
* BREAKING CHANGE : Refactor to handle new `PurchaseStatus` named `canceled`. This means developers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: please update this to follow the new style guide: https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog-style
So it should be:
* **BREAKING CHANGE**: Adds a new `PurchaseStatus` named [...]
Wasn't the plan to do all of flutter/flutter#86076 before doing this? |
@mvanbeusekom Are all the pieces in? I just went through the list from the planned breakage and it seemed like they were all in, but I want to make sure I didn't miss anything. If so, we can update this to cover all of the breaking changes and make it publishable again. |
Yes all issues we discussed are in. Should I prepare an update for this PR or do you prefer to take care of this yourself? |
I'm more likely to get the CHANGELOG wrong, so if you want to update this PR to cover everything (or make a new PR if that's easier) that would be great. |
@stuartmorgan I have updated the CHANGELOG and fixed merge conflicts. Could please have another look at the changelog? |
675603d
to
c701883
Compare
@@ -1,9 +1,13 @@ | |||
## NEXT | |||
## 2.0.0 | |||
|
|||
* Fixes integration tests. | |||
* Updates example app Android compileSdkVersion to 31. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: these two lines should probably go to the end since they are not important to clients. We could swap these with the breaking changes section so that's first (rather than having a sublist in the middle of the list).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the analyzer issues from picking up the deprecation are fixed.
This PR is for updating the
app_facing
plugin's version number andCHANGELOG.md
file since I create two PRs that have the breaking changes to handle the newPurchaseStatus
namedcanceled
in thein_app_purchase_ios
andin_app_purchase_android
platform plugins. This means developers can distinguish between an error and user cancellation.Before merging this PR following PRs have to be merged :
Related issues:
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format
.)[shared_preferences]
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.