This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Begin migrating tools to NNBD #3891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanglaz
suggested changes
May 14, 2021
| platform == kWindows || | ||
| platform == kLinux); | ||
| if (entity == null || entity is! Directory) { | ||
| if (entity is! Directory) { |
Contributor
There was a problem hiding this comment.
I think we can remove this since it is done in the very beginning of the method?
Contributor
Author
There was a problem hiding this comment.
This is the very beginning of the method :)
script/tool/lib/src/common.dart
Outdated
| /// Get the package version on pub. | ||
| Future<PubVersionFinderResponse> getPackageVersion( | ||
| {@required String package}) async { | ||
| {required String? package}) async { |
Contributor
There was a problem hiding this comment.
can be required String package and remove the below assert for != null
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 19, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 19, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 19, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
- Updates dependencies to null-safe versions - Migrates common.dart (which doesn't depend on anything) - Migrates common_tests.dart and its one dependency, utils.dart - Adds build_runner for Mockito mock generation - Adds a new utility methods for getting arguments that handle both the casting and the removal of nullability to address a common problematic pattern while migrating code. - Converts all files, not just the migrated ones, to those new helpers. Migrating common.dart and utils.dart should unblock a command-by-command migration to null safety. Reverts the separate of podspect lints into a step that doesn't do a Flutter upgrade (flutter#3700) because without that step we had a version of Dart too old to run null-safe tooling. First step of flutter/flutter#81912
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating common.dart and utils.dart should unblock a command-by-command migration to null safety.
Reverts the separate of podspect lints into a step that doesn't do a Flutter upgrade
(#3700) because without that step we had a
version of Dart too old to run null-safe tooling.
First step of flutter/flutter#81912
Pre-launch Checklist
dart format. See plugin_tool format)[shared_preferences]///).