Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Enable swift apps depending on plugins with static dependencies #385

Merged
merged 4 commits into from
Feb 15, 2018
Merged

Enable swift apps depending on plugins with static dependencies #385

merged 4 commits into from
Feb 15, 2018

Conversation

szakarias
Copy link
Contributor

This PR along with flutter/flutter#14667 enables swift apps and plugins to depend on Firebase plugins and Google Sign In.

This is achieved by

  1. Overriding the static framework dependency check in the Podfile
  2. In the plugin podspec:

@szakarias
Copy link
Contributor Author

cc @collinjackson

mravn-google
mravn-google approved these changes Feb 13, 2018
View reviewed changes
Copy link
Contributor

@mravn-google mravn-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need changelog entries and version bumps for the changed plugins before republication.

@szakarias szakarias merged commit dacb895 into flutter:master Feb 15, 2018
@szakarias szakarias mentioned this pull request Feb 15, 2018
Closed
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
@szakarias
Enable swift apps depending on plugins with static dependencies (flut…
0eceb9a 
…ter#385)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mravn-google mravn-google mravn-google approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szakarias @mravn-google @googlebot