Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] Image picker phpicker impl #3835

Merged
merged 44 commits into from
May 10, 2021
Merged
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
9496772
Add PHPicker libraries and its delegate
ydag Apr 28, 2021
a4f8416
Add PHPicker implementation
ydag Apr 28, 2021
e8c128c
Refactor UIImagePickerController implementation
ydag Apr 28, 2021
0305c42
Refactor handleMethodCall function
ydag Apr 28, 2021
55cd773
Refactor showPhotoLibrary function
ydag Apr 28, 2021
1516e73
Add the limited access into the photo library
ydag Apr 28, 2021
5b64833
Add the implementation of picker function
ydag Apr 28, 2021
36b6a2a
Refactor Info.plist file
ydag Apr 28, 2021
1d2679a
Add the function to get PHAssetResult
ydag Apr 29, 2021
6566bf0
Change the image to bypass HEIC problem
ydag Apr 29, 2021
a4d2a12
Add UITest to test select photo functionality
ydag Apr 29, 2021
9ed3fcf
Add unit test for PHAssetResult
ydag Apr 29, 2021
7f81b7b
Format the codes in all files
ydag Apr 29, 2021
62bfcfd
Fix the unit test
ydag Apr 29, 2021
97311f9
Update the version
ydag Apr 29, 2021
cc7c5b1
Add the description into CHANGELOG file
ydag Apr 29, 2021
04a8452
Fix the license header
ydag Apr 30, 2021
b930c97
Remove the unnecessary if statement
ydag Apr 30, 2021
9d4c04d
Refactor PHPickerViewController to use property
ydag Apr 30, 2021
0728176
Refactor phPickerFlag state to use property
ydag Apr 30, 2021
852a828
Refactor the code to combine lines
ydag Apr 30, 2021
13e5e9d
Refactor arguments to use property
ydag Apr 30, 2021
aa8a878
Revert formatting changes
ydag Apr 30, 2021
f14c616
Fix the unit test
ydag Apr 30, 2021
7710140
Format the code
ydag Apr 30, 2021
29e5dfd
Refactor the UITest to skip lower versions
ydag May 3, 2021
a83440f
Fix the property's name
ydag May 3, 2021
97f24f8
Refactor the properties to pass them via methods
ydag May 3, 2021
6b295e0
Add the getDesiredImageQuality method
ydag May 3, 2021
f1ae1f2
Add API_AVAILABLE for limited access method
ydag May 3, 2021
30d9597
Refactor PHPickerController to use as a property
ydag May 3, 2021
89a6433
Refactor PHPicker picker method and UITest
ydag May 3, 2021
f3f84b4
Refactor the UITest
ydag May 3, 2021
6e41e86
Change the team to None in the RunnerUITestiOS14
ydag May 3, 2021
55252bf
Fix the UITest
ydag May 4, 2021
4785b7c
Refactor the method to fix dispatch
ydag May 4, 2021
202699c
Change to use self instead of weakSelf
ydag May 4, 2021
aab9714
Fix the UITest to use XCTSkip
ydag May 4, 2021
c04a4dd
Add ImagePickerClassType to use enum
ydag May 5, 2021
615e5a6
Remove unused method
ydag May 5, 2021
362bede
Fix property to change copy to strong
ydag May 6, 2021
4d753d3
Refactor enum
ydag May 6, 2021
049c365
Change argument call
ydag May 6, 2021
0812f61
Add checkPhotoAuthorizationForAccessLevel method
ydag May 7, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor the code to combine lines
  • Loading branch information
ydag committed Apr 30, 2021
commit 852a8282185d387957d8ac09e7086ec8edb133aa
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,8 @@ - (UIViewController *)viewControllerWithWindow:(UIWindow *)window {
}

- (void)pickImageWithPHPicker:(bool)single API_AVAILABLE(ios(14)) {
PHPhotoLibrary *photoLibrary =
PHPhotoLibrary.sharedPhotoLibrary; // This step is required to fetch PHAsset
PHPickerConfiguration *config = [[PHPickerConfiguration alloc] initWithPhotoLibrary:photoLibrary];
PHPickerConfiguration *config =
[[PHPickerConfiguration alloc] initWithPhotoLibrary:PHPhotoLibrary.sharedPhotoLibrary];
if (!single) {
config.selectionLimit = 0; // Setting to zero allow us to pick unlimited photos
}
Expand Down