-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[path_provider] Make a 0.0.5 for Dart 2.12 compat #3672
[path_provider] Make a 0.0.5 for Dart 2.12 compat #3672
Conversation
Anything with a transitive dependency on `path_provider` (which is a lot) is broken on Flutter 1.26 due to Dart FFI changes. path_provider 2.0.0 doesn't have this problem, but for transitive dependencies that means users need to force an override in their pubspec (and more importantly, know that they need to do so). This creates a new minor release to path_provider_windows that uses a 1.26-friendly version of FFI, but has the null safety changes and major version bump backed out, so that transitive dependencies can safely resolve to this working version just by doing a pub update.
I manually tested this by making a new project on Flutter master, adding |
sgtm. The checks on the beta channel should be able to test the dependency resolution, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What makes this work compares to 0.0.4+4? Is the only difference the min dart version? Does the sdk version resolve to a lower version when using 0.4.4+4?
Pinning the |
Oh, I see the confusion. This isn't branched from 0.0.4, it's branched from master, so the important changes are not the diffs |
The automated tests aren't going to test anything meaningful since this is only going to come into play when using path_provider 1.x. I could set up a special test on the branch maybe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
569a4b7
to
1ad924e
Compare
Oops, I forgot to push the reversion to |
Anything with a transitive dependency on
path_provider
(which is alot) is broken on Flutter 1.26 due to Dart FFI changes. path_provider
2.0.0 doesn't have this problem, but for transitive dependencies that
means users need to force an override in their pubspec (and more
importantly, know that they need to do so).
This creates a new minor release to path_provider_windows that uses a
1.26-friendly version of FFI, but has the null safety changes and major
version bump backed out, so that transitive dependencies can safely
resolve to this working version just by doing a pub update.
Should help avoid issues like flutter/flutter#76705
Pre-launch Checklist
[shared_preferences]
///
).