Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[shared_preferences] replace AsyncTask by Executor and Guava Future #3520

Closed

Conversation

hoc081098
Copy link
Contributor

Fixes flutter/flutter#71595
Fixes flutter/flutter#74039

Pre-launch Checklist

  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@SirusCodes
Copy link
Contributor

I already made a PR🤔
#3481

@nyarian
Copy link

nyarian commented Feb 8, 2021

not sure if guava dependency is worth it here, especially when it is all implementable with plain a ExecutorService instance

@stuartmorgan-g
Copy link
Contributor

Closing in favor of the existing PR at #3481. Please comment there if you have feedback on differences between your approach and that one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sharedpreferences not work on android and showing error. SharedPreferences 0.5.12+4 uses AsyncTask API but that is deprecated
4 participants