Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher] Update result to True when the url was loaded successfully. #3475

Merged
merged 8 commits into from
Feb 24, 2021
Merged

[url_launcher] Update result to True when the url was loaded successfully. #3475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
31a712e
Update FLTURLLauncherPlugin.m
lidongze91 Jan 28, 2021
6079602
Merge branch 'lidongze91-patch-1' of github.com:lidongze91/plugins in…
Feb 22, 2021
950140c
Update pubspec.yaml
lidongze91 Feb 22, 2021
15e3bf9
Update CHANGELOG.md
lidongze91 Feb 22, 2021
c70cf67
Merge branch 'master' into lidongze91-patch-1
lidongze91 Feb 22, 2021
2086a69
Merge branch 'master' of github.com:flutter/plugins into lidongze91-p…
Feb 23, 2021
bc94a51
fix conflict
Feb 23, 2021
eb386b9
Undo the re-addition of pre-release changelogs.
stuartmorgan Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/url_launcher/url_launcher/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 6.0.1

* Update result to `True` on iOS when the url was loaded successfully.

## 6.0.0

* Migrate to null safety.
Expand Down
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher/ios/Classes/FLTURLLauncherPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ - (instancetype)initWithUrl:url withFlutterResult:result {
- (void)safariViewController:(SFSafariViewController *)controller
didCompleteInitialLoad:(BOOL)didLoadSuccessfully API_AVAILABLE(ios(9.0)) {
if (didLoadSuccessfully) {
self.flutterResult(nil);
self.flutterResult(@YES);
} else {
self.flutterResult([FlutterError
errorWithCode:@"Error"
Expand Down
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: url_launcher
description: Flutter plugin for launching a URL. Supports
web, phone, SMS, and email schemes.
homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher
version: 6.0.0
version: 6.0.1

flutter:
plugin:
Expand Down