Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[integration_test] Added details to setup the iOS application #3448

Closed
wants to merge 1 commit into from
Closed

[integration_test] Added details to setup the iOS application #3448

wants to merge 1 commit into from

Conversation

letsar
Copy link

@letsar letsar commented Jan 21, 2021

Improved the README by adding details for the iOS section.

This PR aims to fix flutter/flutter#48600

I didn't updated the pubspec.yaml because it's only documentation, but I can do if necessary.

Pre-launch Checklist

  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but the real home of this is now in the Flutter SDK - can you open this PR there?

under packages/integration_test/README.md

@letsar
Copy link
Author

letsar commented Jan 21, 2021

Oh I didn't know, I will make it right away!

@letsar letsar closed this Jan 21, 2021
@letsar letsar deleted the patch-1 branch January 21, 2021 18:25
@neiljaywarner
Copy link

@letsar @dnfield DId this get missed? this is still super confusing afaict
on https://flutter.dev/docs/testing/integration-tests and https://pub.dev/packages/integration_test#ios-device-testing which is linked from there - i.e. the official path.
https://github.com/flutter/flutter/tree/master/packages/integration_test at least looks better from the surface but you can't easily find that from pub.dev or flutter.dev

@dnfield
Copy link
Contributor

dnfield commented Apr 16, 2021

@johnpryan Was working on the documentation for that.

Unfortunately, it might be waiting until the SDK vended version hits stable. It did not make the last stable push but will make the next one.

@neiljaywarner
Copy link

@dnfield thanks for the reply. Should i be using the sdk vended one today a) if i'm on stable channel b) if i'm on beta channel? thanks

@dnfield
Copy link
Contributor

dnfield commented Apr 16, 2021

The SDK vended version is not available on stable yet, but is available on beta.

If you are on beta, you should use it. On stable you don't have a choice.

@neiljaywarner
Copy link

also.. @dnfield i'm still kinda lost even using https://github.com/flutter/flutter/tree/master/packages/integration_test#ios-device-testing
a)
it says to run product->tests . my xcode version (12.4) has product->test, product -> buildfor-test and product->test plan

yes, it would be nice to see the tests run in my simulator..
b) should it be generating an ipa? or what are the two test artifacts? unfortunately I'm using AWS device farm and it wants an ipa first. the instructions dont' mention an ipa and i don't find one yet.

@dnfield
Copy link
Contributor

dnfield commented Apr 16, 2021

I believe @johnpryan has a better handle on where the documentation for this is.

@johnpryan
Copy link
Contributor

In order to add the instructions to flutter.dev we need to validate the instructions from the README and make any improvements along the way. We can use flutter/website#5645 to track.

@neiljaywarner thanks for the feedback

@neiljaywarner
Copy link

The SDK vended version is not available on stable yet, but is available on beta.

If you are on beta, you should use it. On stable you don't have a choice.

@dnfield I switched to beta for this reason and others - eg newer versions of build_runner, build, lots of dependency resolution issues, flutter_driver conflicting with crypto, etc

can you please give me any thoughts on a conservative ETA that today's beta or newer will match stable, especially since today's integration_test on pub.dev is marked deprecated - on how "safe" we are using beta channel, etc?

Thanks so much

@dnfield
Copy link
Contributor

dnfield commented Apr 27, 2021

I don't have an exact date to share, but our release process (https://medium.com/flutter/flutter-spring-2020-update-f723d898d7af) says we do a stable push about once a quarter. You can expect a new stable push sometime this quarter.

If it helps at all, Flutter apps at Google effectively run on dev, and there usually aren't too many changes between beta and stable when we do a release. Sorry I don't have much to share beyond that :)

@johnpryan
Copy link
Contributor

The SDK vended version is not available on stable yet, but is available on beta.

@dnfield Isn't integration_test is available in the stable channel now that Flutter 2.0.0 is out?

DId this get missed? this is still super confusing afaict
on https://flutter.dev/docs/testing/integration-tests and https://pub.dev/packages/integration_test#ios-device-testing which is linked from there - i.e. the official path.
https://github.com/flutter/flutter/tree/master/packages/integration_test at least looks better from the surface but you can't easily find that from pub.dev or flutter.dev

@neiljaywarner This will fix the links in Integration testing page on flutter.dev

@dnfield
Copy link
Contributor

dnfield commented Apr 27, 2021

Yes, but integration_test NNBD is'n't on stable yet - or am I mixing up issues now?

@johnpryan
Copy link
Contributor

I think we're getting off topic from the original issue - @neiljaywarner please follow flutter/flutter#71506 and flutter/flutter#71379 if you are waiting on integration_test to upgrade to null safety. You can import and use the non-null-safe version by using an SDK dependency on the stable channel, though.

@neiljaywarner
Copy link

neiljaywarner commented Apr 27, 2021 via email

@johnpryan
Copy link
Contributor

I am able to import and use the integration_test package by using sdk: flutter in my pubspec on the latest stable channel (2.0.5)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E iOS Documentation unclear
4 participants