Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player]: initial test coverage file() constructor api #3407

Conversation

russellwheatley
Copy link
Contributor

@russellwheatley russellwheatley commented Jan 12, 2021

PR includes a test case for VideoPlayerController.file() constructor which doesn't have an integration test currently.

There are no issues addressed by this PR.

Pre-launch Checklist

  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Jan 12, 2021
@russellwheatley russellwheatley force-pushed the @russell/video-player-file-api-test branch from 9640f73 to 4c5b313 Compare January 12, 2021 16:07
Copy link

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me with just a question on web platform exclusion (or perhaps the opposite: android ios specific inclusion (in case macos is also not supported but toggled on?). Also a note on simulator not working but maybe that's not for file constructor, unknown. The homepage is dire with all the warnings!

@stuartmorgan-g
Copy link
Contributor

Thanks for the submission! We're always happy to see PRs that increase test coverage. We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.

If you could resolve the conflicts here, we can get this landed. The version update can actually just be dropped since this is a test-only change, and thus doesn't need to be published.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I resolved the conflict; LGTM

@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Nov 4, 2021
@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Nov 4, 2021
@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Nov 4, 2021
@fluttergithubbot fluttergithubbot merged commit b401c84 into flutter:master Nov 5, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes p: video_player waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants