This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[google_maps_flutter_web] Render custom Marker icons. #3273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for
fromBytes
BitmapDescriptor
s, so Markers can have programmatically-generated icons in web.This also fixes an issue where custom Marker icons were not being rendered as part of the "initial geometry" (there was a TODO/question about it). Now they should work as expected.
(Tangentially, this also enables
defaultMarkerWithHue
, which can be implemented by computing the bytes of the rotated hue of a default Marker image, similar to the code on this jsfiddle).Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?