[camera] Camera fix android audio #3124

mvanbeusekom · 2020-10-08T10:20:13Z

Description

Extends on the work of @cfchris from pull request #2426 by extracting the logic of creating the MediaRecord instance into a MediaRecordBuilder class (using the builder pattern). This allows us to isolate the code and added the requested unit-tests.

If this pull request is accepted, pull request #2426 will become obsolete.

Related Issues

Fixes flutter/flutter#38787

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

…ndroid-audio

…d-audio

google-cla · 2020-10-08T10:20:38Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2020-10-08T10:21:49Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2020-10-08T10:22:12Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2020-10-08T12:12:33Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

tvolkert

LGTM

cfchris · 2020-10-08T16:24:03Z

@googlebot I consent.

cfchris · 2020-10-08T16:24:44Z

@mvanbeusekom I cloned your fork and tested the example app. It works as expected now. Thank you.

amirh

Left 2 nits, otherwise looks good. Thanks!

amirh · 2020-10-08T19:28:43Z

packages/camera/android/build.gradle

@@ -1,6 +1,6 @@
 group 'io.flutter.plugins.camera'
 version '1.0-SNAPSHOT'
-def args = ["-Xlint:deprecation","-Xlint:unchecked","-Werror"]
+def args = ["-Xlint:deprecation","-Xlint:unchecked"]


Why do we need to remove -Werror? are we hitting warnings we cannot fix?

I was running into some warning when running the (already existing) DartMessengerTest locally. I shouldn't have checked this in. I have reverted the change.

amirh · 2020-10-08T19:30:26Z

packages/camera/android/src/main/java/io/flutter/plugins/camera/media/MediaRecorderBuilder.java

@@ -0,0 +1,70 @@
+package io.flutter.plugins.camera.media;


nit: missing license header

Added missing license header

amirh

LGTM

Fixes flutter/flutter#38787

* Android Code Inspection and Clean up (#3117) * [in_app_purchase] Android Code Inspection and Clean up (#3120) * Android Code Inspection and Clean up * Format * [video_player] Fix SSLProtocolException for low API version (#3122) * [camera] Set audio encoding bitrate when recording video (#3124) Fixes flutter/flutter#38787 * Fix links in package example readmes (#3130) http://flutter.io/ -> https://flutter.dev/ * [integration_test] Add watchPerformance (#3116) * add watchPerformance * [wifi_info_flutter] [wifi_info_flutter_platform_interface] Initial commit for `wifi_info_flutter` plugin and platform interface (#3129) * [video_player] fix Timer Leak (#3119) * [in_app_purchase] Add example test target to Podfile, add OCMock dependency (#3145) * Add linux directory to examples (#3064) When Linux support was added to these plugins, the app template wasn't yet stabilized, so was not checked in. Now that it is stable, this adds them so that the plugin_tools workaround that created them on each run can be removed. Other than CHANGELOG.md updates and updating the verison in pubspec.yaml, this is purely the result of running 'flutter create .' in the example/ folders and adding the resulting linux/ directories. * [wifi_info_flutter_plugin_interface] implement wifi platform interface (#3134) * [share] Replace deprecated Environment.getExternalStorageDirectory() call on Android. (#3152) * Android API 29 & 30 * Update Version * Update android sdk version to 29 for all mobile plugins. (#3042) * [google_sign_in] fix merge error in CHANGELOG (#3153) Co-authored-by: Hamdi Kahloun <32666446+hamdikahloun@users.noreply.github.com> Co-authored-by: Maurits van Beusekom <maurits@baseflow.com> Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com> Co-authored-by: Ming Lyu (CareF) <minglyu@google.com> Co-authored-by: Maurice Parrish <bmparr@google.com> Co-authored-by: creativecreatorormaybenot <creativecreatorormaybenot@gmail.com> Co-authored-by: Jenn Magder <magder@google.com> Co-authored-by: stuartmorgan <stuartmorgan@google.com> Co-authored-by: Chris Yang <ychris@google.com>

Fixes flutter/flutter#38787

cfchris and others added 7 commits December 16, 2019 14:09

Set encoding bitrate to recording bitrate

be25349

Updated version and changlog

5184312

Merge branch 'master' of github.com:flutter/plugins into camera-fix-a…

0a5fce6

…ndroid-audio

Merge branch 'master' of github.com:flutter/plugins into camera-fix-a…

c83f73a

…ndroid-audio

Merge remote-tracking branch 'upstream/master' into camera-fix-androi…

2fe6cfb

…d-audio

Updated version to update PR

c4e09bd

Extracted logic to create MediaRecord and test it.

8c09aa0

mvanbeusekom requested a review from bparrishMines as a code owner October 8, 2020 10:20

google-cla bot added the cla: no label Oct 8, 2020

mvanbeusekom changed the title ~~[Camera] Camera fix android audio~~ [camera] Camera fix android audio Oct 8, 2020

mvanbeusekom mentioned this pull request Oct 8, 2020

[camera] Set encoding bitrate to recording bitrate (fixes 38787) #2426

Closed

13 tasks

Fixed JAVA formatting

fdf2674

tvolkert approved these changes Oct 8, 2020

View reviewed changes

google-cla bot added cla: yes and removed cla: no labels Oct 8, 2020

amirh reviewed Oct 8, 2020

View reviewed changes

Fixed feedback

76c59ac

amirh approved these changes Oct 8, 2020

View reviewed changes

amirh merged commit 66a4b8b into flutter:master Oct 8, 2020

jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020

[camera] Set audio encoding bitrate when recording video (flutter#3124)

e8d0b80

Fixes flutter/flutter#38787

mvanbeusekom deleted the camera-fix-android-audio branch November 2, 2020 09:34

FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020

[camera] Set audio encoding bitrate when recording video (flutter#3124)

fb157ec

Fixes flutter/flutter#38787

cfchris mentioned this pull request Aug 31, 2021

[Camera][iOS] Please restore ability for iPhones to record MPEG-4/H264 (not HEVC/H265) flutter/flutter#89234

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[camera] Camera fix android audio #3124

[camera] Camera fix android audio #3124

Uh oh!

mvanbeusekom commented Oct 8, 2020

Uh oh!

google-cla bot commented Oct 8, 2020

Uh oh!

google-cla bot commented Oct 8, 2020

Uh oh!

google-cla bot commented Oct 8, 2020

Uh oh!

google-cla bot commented Oct 8, 2020

Uh oh!

tvolkert left a comment

Uh oh!

cfchris commented Oct 8, 2020

Uh oh!

cfchris commented Oct 8, 2020

Uh oh!

amirh left a comment

Uh oh!

amirh Oct 8, 2020

Uh oh!

mvanbeusekom Oct 8, 2020 •

edited

Loading

Uh oh!

amirh Oct 8, 2020

Uh oh!

mvanbeusekom Oct 8, 2020

Uh oh!

amirh left a comment

Uh oh!

Uh oh!

[camera] Camera fix android audio #3124

[camera] Camera fix android audio #3124

Uh oh!

Conversation

mvanbeusekom commented Oct 8, 2020

Description

Related Issues

Checklist

Breaking Change

Uh oh!

google-cla bot commented Oct 8, 2020

Uh oh!

google-cla bot commented Oct 8, 2020

Uh oh!

google-cla bot commented Oct 8, 2020

Uh oh!

google-cla bot commented Oct 8, 2020

Uh oh!

tvolkert left a comment

Choose a reason for hiding this comment

Uh oh!

cfchris commented Oct 8, 2020

Uh oh!

cfchris commented Oct 8, 2020

Uh oh!

amirh left a comment

Choose a reason for hiding this comment

Uh oh!

amirh Oct 8, 2020

Choose a reason for hiding this comment

Uh oh!

mvanbeusekom Oct 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amirh Oct 8, 2020

Choose a reason for hiding this comment

Uh oh!

mvanbeusekom Oct 8, 2020

Choose a reason for hiding this comment

Uh oh!

amirh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mvanbeusekom Oct 8, 2020 •

edited

Loading