Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Fix AppStore cancel payment modal #3074

Closed

Conversation

dennis-tra
Copy link
Contributor

@dennis-tra dennis-tra commented Sep 23, 2020

Description

When the user cancels the payment dialog there is no transactionIdentifier this means the transaction cannot be finished in the current implementation and therefore not initiated again.

I haven't polished the PR to be included here, but just wanted to give a heads up. Feel free to close it if it does not meet your standards.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@LHLL LHLL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense. Can you polish it up and add some tests?

@dennis-tra
Copy link
Contributor Author

Hi @LHLL, unfortunately I don't have much time to spare currently, so can't promise any ETA, but it's on my list.

@craigomac
Copy link

This is an incredibly annoying and basic flaw with the plugin. Thanks for your PR!

@dennis-tra
Copy link
Contributor Author

Just created a new PR which updates the tests: #3106

@dennis-tra dennis-tra closed this Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants