Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[path_provider] Path provider windows updates #3049

Merged

Conversation

stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Sep 18, 2020

Description

  • Adds missing iOS podspec to path_provider_windows, which was necessary to publish it (since path_provider doesn't require 1.20+)
  • Requires path_provider_windows 0.0.2, not 0.0.1, in path_provider endorsement.

Related Issues

flutter/flutter#41715

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@stuartmorgan-g stuartmorgan-g changed the title Path provider windows updates [path_provider] Path provider windows updates Sep 18, 2020
@stuartmorgan-g
Copy link
Contributor Author

Added a version bump since the repo tooling requires it. (The previous version wasn't published, but it was checked in, and that's enough apparently.)

@stuartmorgan-g stuartmorgan-g merged commit a83f684 into flutter:master Sep 18, 2020
@stuartmorgan-g stuartmorgan-g deleted the path-provider-windows-updates branch September 18, 2020 18:38
danielroek pushed a commit to Baseflow/flutter-plugins that referenced this pull request Oct 1, 2020
- Adds missing iOS podspec to path_provider_windows, which was necessary to publish it (since path_provider doesn't require 1.20+)
- Requires path_provider_windows 0.0.2, not 0.0.1, in path_provider endorsement.
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
- Adds missing iOS podspec to path_provider_windows, which was necessary to publish it (since path_provider doesn't require 1.20+)
- Requires path_provider_windows 0.0.2, not 0.0.1, in path_provider endorsement.
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
- Adds missing iOS podspec to path_provider_windows, which was necessary to publish it (since path_provider doesn't require 1.20+)
- Requires path_provider_windows 0.0.2, not 0.0.1, in path_provider endorsement.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants