[share] MethodCallHandler.java uses unchecked or unsafe operations #3004

hamdikahloun · 2020-09-07T11:26:17Z

Description

Handle deprecation & unchecked warning as error
Avoiding uses unchecked or unsafe Object Type Casting in MethodCallHandler.java

Related issue : flutter/flutter#65970
A message is displayed when building for android:

flutter build apk
You are building a fat APK that includes binaries for android-arm, android-arm64, android-x64.
If you are deploying the app to the Play Store, it's recommended to use app bundles or split the APK to reduce the APK
size.
    To generate an app bundle, run:
        flutter build appbundle --target-platform android-arm,android-arm64,android-x64
        Learn more on: https://developer.android.com/guide/app-bundle
    To split the APKs per ABI, run:
        flutter build apk --target-platform android-arm,android-arm64,android-x64 --split-per-abi
        Learn more on:  https://developer.android.com/studio/build/configure-apk-splits#configure-abi-split
Note: C:\Users\hamdi\Downloads\plugins-master\packages\share\android\src\main\java\io\flutter\plugins\share\MethodCallHandler.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Removed unused resources: Binary resource data reduced from 46KB to 37KB: Removed 20%
Running Gradle task 'assembleRelease'...
Running Gradle task 'assembleRelease'... Done                     107,9s
√ Built build\app\outputs\flutter-apk\app-release.apk (16.3MB).

flutter build appbundle
Running "flutter pub get" in example...                             0,8s
Note: C:\Users\hamdi\Downloads\plugins-master\packages\share\android\src\main\java\io\flutter\plugins\share\MethodCallHandler.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Removed unused resources: Binary resource data reduced from 36KB to 22KB: Removed 39%
Running Gradle task 'bundleRelease'...
Running Gradle task 'bundleRelease'... Done                        60,2s
√ Built build\app\outputs\bundle\release\app.aab (16.4MB).

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

hamdikahloun · 2020-09-07T13:06:57Z

Hi @cyanglaz
Can you review this PR please.
Thanks

pingbird · 2020-09-10T13:48:21Z

I'm confused, what issue does this solve exactly?

hamdikahloun · 2020-09-10T14:07:47Z

Hi @PixelToast

A message is displayed when building for android:

flutter build apk
You are building a fat APK that includes binaries for android-arm, android-arm64, android-x64.
If you are deploying the app to the Play Store, it's recommended to use app bundles or split the APK to reduce the APK
size.
    To generate an app bundle, run:
        flutter build appbundle --target-platform android-arm,android-arm64,android-x64
        Learn more on: https://developer.android.com/guide/app-bundle
    To split the APKs per ABI, run:
        flutter build apk --target-platform android-arm,android-arm64,android-x64 --split-per-abi
        Learn more on:  https://developer.android.com/studio/build/configure-apk-splits#configure-abi-split
Note: C:\Users\hamdi\Downloads\plugins-master\packages\share\android\src\main\java\io\flutter\plugins\share\MethodCallHandler.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Removed unused resources: Binary resource data reduced from 46KB to 37KB: Removed 20%
Running Gradle task 'assembleRelease'...
Running Gradle task 'assembleRelease'... Done                     107,9s
√ Built build\app\outputs\flutter-apk\app-release.apk (16.3MB).

flutter build appbundle
Running "flutter pub get" in example...                             0,8s
Note: C:\Users\hamdi\Downloads\plugins-master\packages\share\android\src\main\java\io\flutter\plugins\share\MethodCallHandler.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Removed unused resources: Binary resource data reduced from 36KB to 22KB: Removed 39%
Running Gradle task 'bundleRelease'...
Running Gradle task 'bundleRelease'... Done                        60,2s
√ Built build\app\outputs\bundle\release\app.aab (16.4MB).

pingbird · 2020-09-10T14:28:12Z

Ah, I understand the concern, thanks for the PR!

Why not use the generic type parameter of MethodCall.argument to do the casting? Serializing and deserializing definitely isn't the right approach in my opinion.

hamdikahloun · 2020-09-10T14:38:20Z

@PixelToast

(List<String>) call.argument("paths")

Casting Argument to Object will be fine but Casting to List it's unsafe operation.

pingbird · 2020-09-10T19:27:05Z

I don't have a dev environment available at the moment, but would call.argument<List<String>>("paths") work instead of (List<String>) call.argument("paths")?
Before I was referring to https://api.flutter.dev/javadoc/io/flutter/plugin/common/MethodCall.html#argument-java.lang.String- which shows that the argument method is generic.

hamdikahloun · 2020-09-10T19:43:10Z

Thank you for your reply @PixelToast 🥇
i just checked the function argument in MethodCall class and it's so easy !
So why the Object Casting ?

I just pushed the new code

List<String> paths = call.argument("paths");
List<String> mimeTypes = call.argument("mimeTypes");
String text = call.argument("text");
String subject = call.argument("subject");

share.shareFiles(paths, mimeTypes, text, subject);

dnfield · 2020-09-14T18:06:45Z

packages/share/android/src/main/java/io/flutter/plugins/share/MethodCallHandler.java

+          paths = call.argument("paths");
+          mimeTypes = call.argument("mimeTypes");
+          text = call.argument("text");
+          subject = call.argument("subject");


nit: move this out of the try block

@dnfield PR updated . Thank you

dnfield · 2020-09-14T18:08:29Z

packages/share/android/src/main/java/io/flutter/plugins/share/MethodCallHandler.java

@@ -21,23 +21,27 @@

  @Override
  public void onMethodCall(MethodCall call, MethodChannel.Result result) {
+    String text, subject;
+    List<String> paths, mimeTypes;


nit: move to "shareFiles" case, since that's the only place it's used.

Also for these, please use one var per declaration, per https://google.github.io/styleguide/javaguide.html#s4.8.2-variable-declarations

@dnfield PR updated . Thank you

dnfield · 2020-09-14T18:42:49Z

packages/share/android/src/main/java/io/flutter/plugins/share/MethodCallHandler.java

+    String text;
+    String subject;


Sorry for not saying this on the last round, but I think this is going to be a bit more readable if we don't declare these up here, since we don't expect to use them again outside of the block. We can just do String text = and String subject = in the cases that need them.

dnfield

LGTM

…lutter#3004)

hamdikahloun added 2 commits September 7, 2020 12:15

[share] MethodCallHandler.java uses unchecked or unsafe operations

ed86673

[share] MethodCallHandler.java uses unchecked or unsafe operations

cd49311

googlebot added the cla: yes label Sep 7, 2020

hamdikahloun added 2 commits September 7, 2020 12:59

[share] MethodCallHandler.java uses unchecked or unsafe operations

99b5950

[share] MethodCallHandler.java uses unchecked or unsafe operations

2f51f5f

hamdikahloun added 2 commits September 7, 2020 14:40

[share] MethodCallHandler.java uses unchecked or unsafe operations

02d7ef0

[share] MethodCallHandler.java uses unchecked or unsafe operations

6e87f1d

hamdikahloun and others added 6 commits September 10, 2020 21:12

[share] MethodCallHandler.java uses unchecked or unsafe operations

c68a55d

[share] MethodCallHandler.java uses unchecked or unsafe operations

90529c8

[share] MethodCallHandler.java uses unchecked or unsafe operations

cbc56a0

Update MethodCallHandler.java

714864f

Merge remote-tracking branch 'upstream/master'

070697a

Handle deprecation & unchecked warning as error

6299816

dnfield reviewed Sep 14, 2020

View reviewed changes

Update MethodCallHandler.java

2442092

hamdikahloun requested a review from dnfield September 14, 2020 18:35

dnfield reviewed Sep 14, 2020

View reviewed changes

Update MethodCallHandler.java

c906be1

hamdikahloun requested a review from dnfield September 14, 2020 18:55

hamdikahloun mentioned this pull request Sep 16, 2020

[plugins]Deprecation & Unchecked warning flutter/flutter#65970

Closed

dnfield approved these changes Sep 17, 2020

View reviewed changes

dnfield merged commit 17d7548 into flutter:master Sep 17, 2020

danielroek pushed a commit to Baseflow/flutter-plugins that referenced this pull request Sep 18, 2020

[share] MethodCallHandler.java uses unchecked or unsafe operations (f…

72254cf

…lutter#3004)

jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020

[share] MethodCallHandler.java uses unchecked or unsafe operations (f…

f73fbba

…lutter#3004)

FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020

[share] MethodCallHandler.java uses unchecked or unsafe operations (f…

a025867

…lutter#3004)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[share] MethodCallHandler.java uses unchecked or unsafe operations #3004

[share] MethodCallHandler.java uses unchecked or unsafe operations #3004

Uh oh!

hamdikahloun commented Sep 7, 2020 •

edited

Loading

Uh oh!

hamdikahloun commented Sep 7, 2020

Uh oh!

pingbird commented Sep 10, 2020

Uh oh!

hamdikahloun commented Sep 10, 2020 •

edited

Loading

Uh oh!

pingbird commented Sep 10, 2020

Uh oh!

hamdikahloun commented Sep 10, 2020 •

edited

Loading

Uh oh!

pingbird commented Sep 10, 2020

Uh oh!

hamdikahloun commented Sep 10, 2020 •

edited

Loading

Uh oh!

dnfield Sep 14, 2020

Uh oh!

hamdikahloun Sep 14, 2020

Uh oh!

dnfield Sep 14, 2020

Uh oh!

hamdikahloun Sep 14, 2020

Uh oh!

dnfield Sep 14, 2020

Uh oh!

dnfield left a comment

Uh oh!

Uh oh!

[share] MethodCallHandler.java uses unchecked or unsafe operations #3004

[share] MethodCallHandler.java uses unchecked or unsafe operations #3004

Uh oh!

Conversation

hamdikahloun commented Sep 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Breaking Change

Uh oh!

hamdikahloun commented Sep 7, 2020

Uh oh!

pingbird commented Sep 10, 2020

Uh oh!

hamdikahloun commented Sep 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pingbird commented Sep 10, 2020

Uh oh!

hamdikahloun commented Sep 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pingbird commented Sep 10, 2020

Uh oh!

hamdikahloun commented Sep 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dnfield Sep 14, 2020

Choose a reason for hiding this comment

Uh oh!

hamdikahloun Sep 14, 2020

Choose a reason for hiding this comment

Uh oh!

dnfield Sep 14, 2020

Choose a reason for hiding this comment

Uh oh!

hamdikahloun Sep 14, 2020

Choose a reason for hiding this comment

Uh oh!

dnfield Sep 14, 2020

Choose a reason for hiding this comment

Uh oh!

dnfield left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hamdikahloun commented Sep 7, 2020 •

edited

Loading

hamdikahloun commented Sep 10, 2020 •

edited

Loading

hamdikahloun commented Sep 10, 2020 •

edited

Loading

hamdikahloun commented Sep 10, 2020 •

edited

Loading