Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

MORE SHARDS MEANS MORE CI #2936

Merged
merged 11 commits into from
Aug 18, 2020
Merged

MORE SHARDS MEANS MORE CI #2936

merged 11 commits into from
Aug 18, 2020

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Aug 17, 2020

Shard some tests that have been timing out some more.

Specifically, increase the shard count of build-apks+java-test+firebase-test-lab from 2 to 4.

@dnfield
Copy link
Contributor Author

dnfield commented Aug 17, 2020

If this passes, it will have to be landed on red, since the failure on master is a timeout that this is meant to help fix/work around.

@ditman
Copy link
Member

ditman commented Aug 17, 2020

Currently this is being throttled by Cirrus (limit of concurrent community tasks reached)

@dnfield
Copy link
Contributor Author

dnfield commented Aug 18, 2020

The real problem was that the shards were not actually sharding the tests. I fixed the bash script, still adding a couple more shards to match what iOS is doing. We can revert that part of we think it's slowing things down for scheduling.

Going to land this on red to get the tree back to green once it passes. TBR @ditman @cyanglaz

@dnfield dnfield merged commit d93d408 into flutter:master Aug 18, 2020
@dnfield dnfield deleted the moar_shards branch August 18, 2020 06:49
jarrodcolburn pushed a commit to jarrodcolburn/plugins that referenced this pull request Aug 20, 2020
* Use shard variables correctly in incremental_build.sh
* Add more shards for the apk tasks.
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
* Use shard variables correctly in incremental_build.sh
* Add more shards for the apk tasks.
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
* Use shard variables correctly in incremental_build.sh
* Add more shards for the apk tasks.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants