This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[url_launcher] Endorse url_launcher_linux #2863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an endorsement for url_launcher_linux, so that Linux is supported automatically. Part of flutter/flutter#41721
cyanglaz
reviewed
Jul 7, 2020
| // Generally all devices should have some default SMS app. | ||
| expect(await canLaunch('sms:5555555555'), true); | ||
| // SMS handling is available by default on most platforms. | ||
| if (kIsWeb || !Platform.isLinux) { |
There was a problem hiding this comment.
just curious: Does Platform.isLinux include web on linux?
There was a problem hiding this comment.
IIRC Platform.isFoo explodes when run on web.
That's just the result of running |
cyanglaz
approved these changes
Jul 7, 2020
agent3bood
pushed a commit
to agent3bood/flutter-plugins
that referenced
this pull request
Jul 10, 2020
Adds an endorsement for url_launcher_linux, so that Linux is supported automatically. Part of flutter/flutter#41721
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
Adds an endorsement for url_launcher_linux, so that Linux is supported automatically. Part of flutter/flutter#41721
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Adds an endorsement for url_launcher_linux, so that Linux is supported automatically. Part of flutter/flutter#41721
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an endorsement for url_launcher_linux, so that Linux is supported
automatically.
Related Issues
Part of flutter/flutter#41721
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?