Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[e2e] Fix e2e pixel ratio #2842

Merged
merged 3 commits into from
Jun 23, 2020
Merged

[e2e] Fix e2e pixel ratio #2842

merged 3 commits into from
Jun 23, 2020

Conversation

CareF
Copy link
Contributor

@CareF CareF commented Jun 23, 2020

Description

Fix the device pixel ratio for e2e.

According to https://api.flutter.dev/flutter/flutter_test/TestViewConfiguration-class.html the size of TestViewConfiguration constructor is in logical pixels.

Related Issues

flutter/flutter#59880

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@CareF CareF requested a review from digiter as a code owner June 23, 2020 04:25
@CareF CareF changed the title Fix e2e pixel ratio [e2e] Fix e2e pixel ratio Jun 23, 2020
@CareF
Copy link
Contributor Author

CareF commented Jun 23, 2020

cc @liyuqian

liyuqian
liyuqian reviewed Jun 23, 2020
View reviewed changes
Copy link

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM! CC @dnfield to see if there's any more comment.

@liyuqian liyuqian requested a review from dnfield June 23, 2020 17:51
@dnfield dnfield merged commit a0e8806 into flutter:master Jun 23, 2020
@CareF CareF deleted the fix_e2e_pixel_ratio branch June 23, 2020 18:26
agent3bood pushed a commit to agent3bood/flutter-plugins that referenced this pull request Jul 10, 2020
@CareF @agent3bood
[e2e] Fix e2e pixel ratio (flutter#2842)
df2371f 
* Fix e2e device pixel ratio

* Update changelog and version

* Formatting
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
@CareF @jorgefspereira
[e2e] Fix e2e pixel ratio (flutter#2842)
7619115 
* Fix e2e device pixel ratio

* Update changelog and version

* Formatting
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
@CareF
[e2e] Fix e2e pixel ratio (flutter#2842)
0555023 
* Fix e2e device pixel ratio

* Update changelog and version

* Formatting
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liyuqian liyuqian liyuqian left review comments

@dnfield dnfield dnfield approved these changes

@digiter digiter Awaiting requested review from digiter

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CareF @dnfield @liyuqian @googlebot