Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher] launch should return true on success. #2787

Closed
wants to merge 2 commits into from
Closed

[url_launcher] launch should return true on success. #2787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b68a94
url_launcher.launch should return true on success.
chingjun May 21, 2020
6b58acb
Update CHANGELOG and pubspec
chingjun May 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/url_launcher/url_launcher/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 5.4.10

* iOS plugin now returns true instead of null on success when forceSafariVC is true.

## 5.4.9

* Update README.
Expand Down
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher/ios/Classes/FLTURLLauncherPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ - (instancetype)initWithUrl:url withFlutterResult:result {
- (void)safariViewController:(SFSafariViewController *)controller
didCompleteInitialLoad:(BOOL)didLoadSuccessfully API_AVAILABLE(ios(9.0)) {
if (didLoadSuccessfully) {
self.flutterResult(nil);
self.flutterResult(@(YES));
} else {
self.flutterResult([FlutterError
errorWithCode:@"Error"
Expand Down
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: url_launcher
description: Flutter plugin for launching a URL on Android and iOS. Supports
web, phone, SMS, and email schemes.
homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher
version: 5.4.9
version: 5.4.10

flutter:
plugin:
Expand Down