Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher] update README with enableJavaScript info #2766

Merged
merged 2 commits into from
May 16, 2020
Merged

[url_launcher] update README with enableJavaScript info #2766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8d6094
update README with enableJavaScript info
cg021 May 15, 2020
ea4371e
Merge branch 'master' into fix/30464
cg021 May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/url_launcher/url_launcher/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 5.4.9
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyanglaz what is the pattern for bumping plugin versions? I see that in some cases it's a patch, and in other cases it's a minor bump.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a patch as there is no public api changes.
A non-breaking public api change would require a minor bump.
https://dart.dev/tools/pub/versioning#semantic-versions

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we strictly follow that though?


* Update README.

## 5.4.8

* Initialize `previousAutomaticSystemUiAdjustment` in launch method.
Expand Down
4 changes: 3 additions & 1 deletion packages/url_launcher/url_launcher/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ web page using a URL following the `http` scheme.

## Browser vs In-app Handling
By default, Android opens up a browser when handling URLs. You can pass
forceWebView: true parameter to tell the plugin to open a WebView instead. On
`forceWebView: true` parameter to tell the plugin to open a WebView instead.
If you do this for a URL of a page containing JavaScript, make sure to pass in
`enableJavaScript: true`, or else the launch method will not work properly. On
iOS, the default behavior is to open all web URLs within the app. Everything
else is redirected to the app handler.
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: url_launcher
description: Flutter plugin for launching a URL on Android and iOS. Supports
web, phone, SMS, and email schemes.
homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher
version: 5.4.8
version: 5.4.9

flutter:
plugin:
Expand Down