Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] fix to properly place polyline at initial camera position in example app #2732

Closed

Conversation

klaes-ashford
Copy link
Contributor

@klaes-ashford klaes-ashford commented May 3, 2020

Description

since in the code _polylineIdCounter is used to offset the latitude and it being 2 for initial polyline, goes out of the map viewport and when ever you add a polyline it is not visible at first. you have to pan around to see the initially added polyline. This at first gives a false impression that the polyline is not working. this change when merged will fix that issue.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@klaes-ashford
Copy link
Contributor Author

@cyanglaz this being a small fix in example app, I am not sure if I should add a changelog since none of the api's is being touched.

@cyanglaz
Copy link
Contributor

cyanglaz commented May 4, 2020

Thank you for sending this PR. Yes, we need to update the CHANGLOG and version for a fix in the example app. Could you explain more in detail what are you trying to fix here? Is there an issue that you can link this to?

@klaes-ashford
Copy link
Contributor Author

ezgif-5-171a032b2f8d

as you can see in the gif, initially, you can not see the polyline at first when you click the add button. you have to pan around to see the polyline. this might confuse a naive user (it occured to me :P), so I thought, it would be great to see the initial polyline at first time itself.

@cyanglaz with a slight modification to the initialCameraPosition latitude we can place the initial polyline to the center of view port.

@cyanglaz
Copy link
Contributor

cyanglaz commented May 4, 2020

@aswinkviswanath I see thanks for the fix! Please update the changelog and version. I will land this!

@klaes-ashford
Copy link
Contributor Author

@cyanglaz CHANGELOG and version updated.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@cyanglaz
Copy link
Contributor

@klaes-ashford The PR is almost ready to merge, it looks like you have to sign the CLA.

@klaes-ashford
Copy link
Contributor Author

@cyanglaz Sorry, but I used the wrong email address in PR, and I don't have access to the same.

@klaes-ashford
Copy link
Contributor Author

@cyanglaz please see #2941. These changes have been moved there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants