-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[google_maps_flutter] fix to properly place polyline at initial camera position in example app #2732
Conversation
@cyanglaz this being a small fix in example app, I am not sure if I should add a changelog since none of the api's is being touched. |
Thank you for sending this PR. Yes, we need to update the CHANGLOG and version for a fix in the example app. Could you explain more in detail what are you trying to fix here? Is there an issue that you can link this to? |
as you can see in the gif, initially, you can not see the polyline at first when you click the add button. you have to pan around to see the polyline. this might confuse a naive user (it occured to me :P), so I thought, it would be great to see the initial polyline at first time itself. @cyanglaz with a slight modification to the initialCameraPosition latitude we can place the initial polyline to the center of view port. |
@aswinkviswanath I see thanks for the fix! Please update the changelog and version. I will land this! |
@cyanglaz CHANGELOG and version updated. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@klaes-ashford The PR is almost ready to merge, it looks like you have to sign the CLA. |
@cyanglaz Sorry, but I used the wrong email address in PR, and I don't have access to the same. |
Description
since in the code
_polylineIdCounter
is used to offset the latitude and it being 2 for initial polyline, goes out of the map viewport and when ever you add a polyline it is not visible at first. you have to pan around to see the initially added polyline. This at first gives a false impression that the polyline is not working. this change when merged will fix that issue.Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?