[google_maps_flutter] Introduce Platform Interface package. #2637

ditman · 2020-04-07T00:44:48Z

Description

This is the initial version of the Platform Interface package for the federation of the google_maps_flutter plugin.

The original work happened in this other PoC PR: #2577.

This PR prepares the package to be published in pub.dev.

Related Issues

[google_maps_flutter] Support google_maps_flutter on web flutter#45292

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

No, this is not a breaking change.

* Make the method_channel implementation private, so it can't be imported from other packages. * Fix all the problems with Future<void> functions not returning a future.

…ort from core plugin to maintain current API.

…by other toJson methods.

…port from the core plugin to preserve public API.

…Json where needed.

methods. Update MethodChannel implementation and plugin to new API.

use the appropriate classes. Move as much logic as possible to the MethodChannel.

Update the MethodChannel and core plugin implementation to the new API.

The interface can be a singleton, but implementations can still keep references to multiple different method channels.

Wire them up in the method channel. Add Event types so we can filter views of the stream later.

googlebot · 2020-04-07T00:45:35Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

ditman · 2020-04-07T00:49:24Z

Please @cylyl, can you do this?

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

…gins script.

cylyl · 2020-04-09T03:22:00Z

@googlebot I consent.
CLAs look good, thanks!

googlebot · 2020-04-09T03:25:18Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

ditman · 2020-04-09T17:45:28Z

Thanks @cylyl!!

Please @hterkelsen, @cyanglaz, can you take a look? This one seems ready to ship! (it's the same you've seen before, but without the changes to the core plugin)

cyanglaz

LGTM based on my review in #2577

ditman · 2020-04-20T20:40:09Z

I'm going to merge this, and post another one with the required updates to the core plugin. Thanks for the review @cyanglaz!

…e. (flutter#2637) (#330) This package contains the platform interface (and the MethodChannel default implementation) for the Google Maps Flutter plugin, up to version 0.5.26. The most drastic change is including Streams of MapEvents for all different types of events that may come from the native side. Core types of the plugin (LatLng, Marker, Circle...) now live in this package. Co-authored-by: chung2012 <chungyl2012@gmail.com>

…e. (flutter#2637) This package contains the platform interface (and the MethodChannel default implementation) for the Google Maps Flutter plugin, up to version 0.5.26. The most drastic change is including Streams of MapEvents for all different types of events that may come from the native side. Core types of the plugin (LatLng, Marker, Circle...) now live in this package. Co-authored-by: chung2012 <chungyl2012@gmail.com>

tolotrasamuel · 2020-09-15T12:28:55Z

@ditman can you please assist on this flutter/flutter#65788 ?

I made a PR on google_maps_flutter. However, google_maps_flutter depends on google_maps_flutter_platform_interface and my PR needed to modify both plugins.

So I changed pubspec.yaml as follow in google_maps_flutter

dependencies:
  flutter:
    sdk: flutter
  flutter_plugin_android_lifecycle: ^1.0.0
  google_maps_flutter_platform_interface: # I changed this from ^1.0.4
    path: ../google_maps_flutter_platform_interface

Then I did the Pull Request but on of the checks says:

* Don't depend on "google_maps_flutter_platform_interface" from the path source. Use the hosted source instead. For example:

I don't understand. How am I supposed to use the hosted plugin although I am modifying it

This is my PR https://github.com/flutter/plugins/pull/3027/checks?check_run_id=1117524341

…e. (flutter#2637) This package contains the platform interface (and the MethodChannel default implementation) for the Google Maps Flutter plugin, up to version 0.5.26. The most drastic change is including Streams of MapEvents for all different types of events that may come from the native side. Core types of the plugin (LatLng, Marker, Circle...) now live in this package. Co-authored-by: chung2012 <chungyl2012@gmail.com>

cylyl and others added 30 commits April 6, 2020 17:34

add google_maps_flutter_platform_interface

612722c

removed unused_local_variable

b979907

format

942a333

format

b083e31

format#

77c3e78

update CHANGELOG

6693617

Move MethodChannel code to MethodChannelGoogleMapsFlutter

e186406

Update dependencies

75d8376

add buildView method

47180d6

update pubspec

2140abb

bugs fix

2908711

Some adjustments to the PR.

d1498be

* Make the method_channel implementation private, so it can't be imported from other packages. * Fix all the problems with Future<void> functions not returning a future.

dartfmt -w .

29fd8c6

Expose the MethodChannel so e2e tests are happy.

130b187

Move platform into src so we can create a barrel file to export stuff.

aa883eb

Create barrel file to export only certain things from src

62dfefa

Adjust imports in platform interface

eb89c8d

Move LatLng and LagLngBounds to the platform interface package. Reexp…

e864e05

…ort from core plugin to maintain current API.

Move ui.dart to platform_interface. Expose .toJson so it can be used …

a2a4f6f

…by other toJson methods.

Move Polygon and Polyline, and all the related types.

87ae109

Move Circle and Marker files to platform_interface.

fca65f7

Move callbacks, camera and screen cordinate to platform interface. Ex…

891f7d0

…port from the core plugin to preserve public API.

Adapt controller and map widget to new API. Expose _toX methods as to…

add2755

…Json where needed.

dartfmt -w .

117c5fa

Use EntityUpdate classes in the corresponding platform interface

bde0b79

methods. Update MethodChannel implementation and plugin to new API.

Modify the platform interface in methods that return map boundaries to

5dbee85

use the appropriate classes. Move as much logic as possible to the MethodChannel.

Utilize MarkerId instances instead of Strings in the relevant methods.

626b551

Update the MethodChannel and core plugin implementation to the new API.

Return futures from the platform directly, no need to await for those.

41f9915

Make mapId a mandatory parameter on the interface methods.

9cb7a45

The interface can be a singleton, but implementations can still keep references to multiple different method channels.

Add the 11 native event Streams to the platform interface.

2e6c763

Wire them up in the method channel. Add Event types so we can filter views of the stream later.

ditman added 7 commits April 6, 2020 17:34

Appease the analyzer.

0aa8f86

Appease analyze some more.

0143254

Rename _controller to _mapEventStreamController

e2113b1

Update some docs on the platform

e04081c

Document MapEvent constructors.

7774184

Document method_channel class

97ebb01

Revert all changes to core plugin.

e7179b5

ditman changed the title ~~Gmaps platform interface~~ [google_maps_flutter] Introduce Platform Interface package. Apr 7, 2020

googlebot added the cla: no label Apr 7, 2020

ditman mentioned this pull request Apr 7, 2020

[google_maps_flutter] Add Google maps flutter platform interface #2577

Closed

12 tasks

ditman requested review from cyanglaz and harryterkelsen April 7, 2020 00:48

Exclude google_maps platform interface and web from the build_all_plu…

3ccc6c0

…gins script.

googlebot added cla: yes and removed cla: no labels Apr 9, 2020

cyanglaz approved these changes Apr 20, 2020

View reviewed changes

ditman merged commit 514b7a1 into flutter:master Apr 20, 2020

ditman deleted the gmaps_platform_interface branch April 20, 2020 20:51

ditman mentioned this pull request Apr 20, 2020

[google_maps_flutter] Introduce google_maps_flutter_platform_interfac… ditman/flutter-plugins#330

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[google_maps_flutter] Introduce Platform Interface package. #2637

[google_maps_flutter] Introduce Platform Interface package. #2637

Uh oh!

ditman commented Apr 7, 2020

Uh oh!

googlebot commented Apr 7, 2020

Uh oh!

ditman commented Apr 7, 2020

Uh oh!

cylyl commented Apr 9, 2020 •

edited

Loading

Uh oh!

googlebot commented Apr 9, 2020

Uh oh!

ditman commented Apr 9, 2020

Uh oh!

cyanglaz left a comment

Uh oh!

ditman commented Apr 20, 2020

Uh oh!

tolotrasamuel commented Sep 15, 2020

Uh oh!

Uh oh!

[google_maps_flutter] Introduce Platform Interface package. #2637

[google_maps_flutter] Introduce Platform Interface package. #2637

Uh oh!

Conversation

ditman commented Apr 7, 2020

Description

Related Issues

Checklist

Breaking Change

Uh oh!

googlebot commented Apr 7, 2020

Uh oh!

ditman commented Apr 7, 2020

Uh oh!

cylyl commented Apr 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Apr 9, 2020

Uh oh!

ditman commented Apr 9, 2020

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

ditman commented Apr 20, 2020

Uh oh!

tolotrasamuel commented Sep 15, 2020

Uh oh!

Uh oh!

cylyl commented Apr 9, 2020 •

edited

Loading