This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[e2e] Replaces the check for ActivityTestRule #2633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st for GrantPermissionRule
ened
changed the title
digiter
suggested changes
Apr 13, 2020
...android/app/src/androidTest/java/com/example/e2e_example/MainActivityWithPermissionTest.java
Show resolved
Hide resolved
|
@digiter addressed your feedback, thank you for the review. FYI: There are other "@rule" that the E2E test should support but there needs to be some back channel to get the information on the applied rules (or the name of the test if you will) to the Dart side of the E2E test. This should be work for a future PR. |
digiter
approved these changes
Apr 14, 2020
|
@digiter PR is merged, could you please publish on pub when you get a chance? |
cyanglaz
pushed a commit
that referenced
this pull request
Apr 15, 2020
This reverts commit a811e63.
cyanglaz
pushed a commit
that referenced
this pull request
Apr 15, 2020
|
@cyanglaz the error seems to come from video_player_web.. not sure what I'm looking for, yet. |
ened
added a commit
to ened/plugins
that referenced
this pull request
Apr 17, 2020
This reverts commit 6087741.
12 tasks
ened
added a commit
that referenced
this pull request
Apr 17, 2020
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
Android: Replaces the check for ActivityTestRule and adds a second test for GrantPermissionRule enabled tests
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
…flutter#2657) This reverts commit a811e63.
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
…lutter#2661) This reverts commit 6087741.
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
Android: Replaces the check for ActivityTestRule and adds a second test for GrantPermissionRule enabled tests
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
…flutter#2657) This reverts commit a811e63.
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
…lutter#2661) This reverts commit 6087741.
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Android: Replaces the check for ActivityTestRule and adds a second test for GrantPermissionRule enabled tests
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
…flutter#2657) This reverts commit a811e63.
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
…lutter#2661) This reverts commit 6087741.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue outlined in flutter/flutter#53660.
Related issues
Fixes flutter/flutter#53660.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?