This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[video_player_web] Play videos from assets #2384
Merged
+51
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinjackson
approved these changes
Dec 9, 2019
packages/video_player/video_player_web/lib/video_player_web.dart
Outdated
Show resolved
Hide resolved
packages/video_player/video_player_web/lib/video_player_web.dart
Outdated
Show resolved
Hide resolved
ditman
approved these changes
Dec 9, 2019
ditman
reviewed
Dec 9, 2019
| @@ -1,6 +1,5 @@ | |||
| name: video_player_platform_interface | |||
| description: A common platform interface for the video_player plugin. | |||
| author: Flutter Team <flutter-dev@googlegroups.com> | |||
There was a problem hiding this comment.
Analyzer complains that you didn't update the version for this one
we will fix this when we update the pubspecs for this package
eugenejeonme
added a commit
to COMANDKEYINC/flutter_plugins
that referenced
this pull request
Dec 11, 2019
This reverts commit 24c042e. # Conflicts: # packages/video_player/video_player_web/CHANGELOG.md # packages/video_player/video_player_web/pubspec.yaml
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
* [video_player_web] Add support for asset DataSources * Roll pub version * Remove deprecated author field * Respond to review comments * Add back author field * Delete author field again * Fix pubspecs * Fix handling of packages * add back author to platform interface we will fix this when we update the pubspecs for this package
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
* [video_player_web] Add support for asset DataSources * Roll pub version * Remove deprecated author field * Respond to review comments * Add back author field * Delete author field again * Fix pubspecs * Fix handling of packages * add back author to platform interface we will fix this when we update the pubspecs for this package
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows us to play videos that are provided as assets.
Related Issues
Fixes flutter/flutter#46621
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?